Generalize extra_database_entry method#504
Closed
nkanazawa1989 wants to merge 1 commit into
Closed
Conversation
Collaborator
|
IMO going this way clutters the base class API unnecessarily since in the context of that class it is just more analysis and should be in the subclasses run analysis method. I think it would be better to add some configurable options to CompositeAnalysis as I started discussing in #509, that you can use when subclassing that class for specialized analysis such as you are doing in the HEAT experiment, let's discuss this in more detail offline for your specific use case there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In #460, parameters of interest are computed based on child experiment parameters in the batch, however, there is no approach to write this workflow except for overriding
_run_analysis. This needs the parent analysis to block for callback of child analysis, otherwise it fails with no entry error.Details and comments
This PR generalize
_extra_database_entrymethod that has been existing inCurveAnalysis. This method is designed to take analyzed dataset and compute new values to return. This part is moved to base analysis, as second callback attached to experiment data. This chained callback should be computed sequentially, thus we don't need to manage callback sync in child classes.