Remove version pins on documentation dependencies#1375
Merged
Conversation
Some of the pinned versions have gotten old and are confusing pip's resolver as it tries to find versions of the unpinned dependencies which are compatible with the pinned dependencies. The issues that led to the versions being pinned should be resolved.
Collaborator
Author
|
I organized the dependencies so it is easier to check for things. The obscures somewhat what pins were removed. The removed ones were: jupyter-client, ipython, ipykernel -- all removed entirely since they were just pinned because new releases broke packages we actually depended on. sphinx, qiskit-sphinx-theme -- removed the upper bound on these dependencies. There are still bounds on black and pylint which we might remove or raise later. |
coruscating
approved these changes
Jan 26, 2024
Collaborator
coruscating
left a comment
coruscating
left a comment
There was a problem hiding this comment.
The built docs still look good after removing the pins. Thanks for organizing the file!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the pinned versions have gotten old and are confusing pip's resolver as it tries to find versions of the unpinned dependencies which are compatible with the pinned dependencies. The issues that led to the versions being pinned should be resolved.