This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Fixing tests failing due to numpy eigh sign convention changes#172
Merged
Conversation
ihincks
reviewed
Dec 19, 2022
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
ihincks
approved these changes
Dec 19, 2022
DanPuzzuoli
added a commit
to DanPuzzuoli/qiskit-dynamics
that referenced
this pull request
Jan 5, 2023
to24toro
pushed a commit
to to24toro/qiskit-dynamics
that referenced
this pull request
Feb 2, 2023
…t-community#172) Co-authored-by: Ian Hincks <ian.hincks@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #171.
As described in #171, a numpy update cause signs of eigenvectors output by
eighto change in some tests. While the output is mathematically correct in both cases, our tests were dependent on the exact value of the entries of the eigenvectors, leading to errors.Both tests have been modified to be independent of the sign of the eigenvectors output of
eigh, avoiding this issue.