Stop using basic aer internal private attributes#1554
Conversation
This commit fixes the usage of internal only explicitly private attributes of basicaer's job class. These look they were used to manually create a job id which was manually set ahead of time despite still being a random uuid and then launching a simulation from that constructed job object. Which is both the incorrect order to run a simulation (runs generate jobs, not the other way around) but also served no functional purpose. This commit removes this as this is a blocker for Qiskit/qiskit#5218 which is upgrading the basic aer provider to use the latest versioned provider interface which removes all of those private methods and also moves to a synchronous execution model.
mtreinish
requested review from
levbishop,
manoelmarques and
woodsp-ibm
as code owners
Fix copyright
woodsp-ibm
left a comment
woodsp-ibm
left a comment
There was a problem hiding this comment.
From what I recall the code has been around quite some time. It was more or less a copy of the code from the simulators that created and submitted a job. It was done so we could skip doing the qobj validation, which the simulators used to do, which used to take a significant amount of time. At least this is my best recollection. If it can be simpler now its fine.
Yeah, the simulator run path used to actually do validation 3 times, once in qobj generation via marshmallow, once in jsonschema, and then once again in the simulator code, but even once was pointless and didn't accomplish anything (since it was all internal to qiskit). It was a real mess and a complete waste of electricity. I removed all of that a long time ago once I saw how awful it all was. Most of this code (in the migrated terra side version) will need to be removed anyway since it doesn't serve a purpose with the new backends interface (and there not being a qobj anymore), but that's a later refactor. |
3 participants
Summary
This commit fixes the usage of internal only explicitly private
attributes of basicaer's job class. These look they were used to
manually create a job id which was manually set ahead of time despite
still being a random uuid and then launching a simulation from that
constructed job object. Which is both the incorrect order to run a
simulation (runs generate jobs, not the other way around) but also
served no functional purpose. This commit removes this as this is a
blocker for Qiskit/qiskit#5128 which is upgrading the basic aer
provider to use the latest versioned provider interface which removes
all of those private methods and also moves to a synchronous execution
model.
Details and comments
This needs to be included in the next 0.9 release to unblock Qiskit/qiskit#5128 (I had to make the same change in that PR to fix basic aer usage with the migrated code in terra)