Skip to content
This repository has been archived by the owner on Dec 7, 2021. It is now read-only.

Enhanced Aqgd optimizer #1252

Merged
merged 16 commits into from
Sep 21, 2020
Merged

Enhanced Aqgd optimizer #1252

merged 16 commits into from
Sep 21, 2020

Conversation

pbark
Copy link
Collaborator

@pbark pbark commented Sep 16, 2020

Summary

New advanced AQDG optimizer using Epochs added

Details and comments

Panagiotis Barkoutsos and others added 3 commits May 28, 2020 19:56
@pbark pbark requested a review from adekusar-drl September 16, 2020 09:09
@pbark pbark added this to the 0.8 milestone Sep 16, 2020
@adekusar-drl
Copy link
Contributor

@pbark Could you please add a reno file with a description of the changes?

woodsp-ibm
woodsp-ibm suggested changes Sep 16, 2020
View reviewed changes
qiskit/aqua/components/optimizers/aqgd.py Outdated Show resolved Hide resolved
qiskit/aqua/components/optimizers/aqgd.py Outdated Show resolved Hide resolved
qiskit/aqua/components/optimizers/aqgd.py Outdated Show resolved Hide resolved
qiskit/aqua/components/optimizers/aqgd.py Outdated Show resolved Hide resolved
qiskit/aqua/components/optimizers/aqgd.py Outdated Show resolved Hide resolved
qiskit/aqua/components/optimizers/aqgd.py Outdated Show resolved Hide resolved
qiskit/aqua/components/optimizers/aqgd.py Outdated Show resolved Hide resolved
test/aqua/test_optimizer_aqqd.py Outdated Show resolved Hide resolved
releasenotes/notes/aqgd-epochs-8e6ad87971e8e2db.yaml Outdated Show resolved Hide resolved
qiskit/aqua/components/optimizers/aqgd.py Outdated Show resolved Hide resolved
@adekusar-drl
Copy link
Contributor

CI failed at:
pip._vendor.urllib3.exceptions.ProtocolError: ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))
while downloading pytorch as I see.

@pbark
Copy link
Collaborator Author

pbark commented Sep 17, 2020

CI failed at:
pip._vendor.urllib3.exceptions.ProtocolError: ("Connection broken: ConnectionResetError(104, 'Connection reset by peer')", ConnectionResetError(104, 'Connection reset by peer'))
while downloading pytorch as I see.

I restarted the CI. Locally I pass all the tests.

woodsp-ibm
woodsp-ibm reviewed Sep 17, 2020
View reviewed changes
qiskit/aqua/components/optimizers/aqgd.py Outdated
self._tol = tol
self._averaging = averaging
if disp:
warnings.warn('disp deprecated, enable logging instead.', DeprecationWarning)
Copy link
Member

@woodsp-ibm woodsp-ibm Sep 17, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we include the more complete text such as below (I tried as a suggestion but the formatting seemed all over the place while it lines up fine in this view while I am editing it, it does not in the outcome

            warnings.warn('The disp parameter is deprecated as of '
                                   '0.8.0 and will be removed no sooner than 3 months after the release. '
                                   'The information is now available if you enable INFO level logging.',
                                   DeprecationWarning, stacklevel=2)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

woodsp-ibm
woodsp-ibm reviewed Sep 17, 2020
View reviewed changes
test/aqua/test_optimizer_aqqd.py
seed_simulator=aqua_globals.random_seed,
seed_transpiler=aqua_globals.random_seed))
self.assertAlmostEqual(result.eigenvalue.real, -1.857275, places=5)
q_instance = QuantumInstance(BasicAer.get_backend('statevector_simulator'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please split this into 3 separate tests so if there is a failure its easier to pinpoint it to a specific test aspect

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done.

@woodsp-ibm woodsp-ibm added the Changelog: New Feature Include in the Added section of the changelog label Sep 17, 2020
@pbark pbark merged commit 24145f3 into qiskit-community:master Sep 21, 2020
@pbark pbark deleted the aqgd branch September 21, 2020 10:41
mtreinish pushed a commit to mtreinish/qiskit-core that referenced this pull request Nov 20, 2020
@adekusar-drl @woodsp-ibm
Enhanced Aqgd optimizer (qiskit-community/qiskit-aqua#1252)
c812b78 
* new advanced aqgd added

* fix in license

* cleaning, linting

* spelling

* more spelling

* reno added

* Update qiskit/aqua/components/optimizers/aqgd.py

Co-authored-by: Steve Wood <[email protected]>

* Update qiskit/aqua/components/optimizers/aqgd.py

Co-authored-by: Steve Wood <[email protected]>

* code review

* updated release note aqgd

* code review 2

Co-authored-by: Anton Dekusar <[email protected]>
Co-authored-by: Anton Dekusar <[email protected]>
Co-authored-by: Steve Wood <[email protected]>
manoelmarques pushed a commit to manoelmarques/qiskit-terra that referenced this pull request Dec 7, 2020
@adekusar-drl @woodsp-ibm
Enhanced Aqgd optimizer (qiskit-community/qiskit-aqua#1252)
33b98c1 
* new advanced aqgd added

* fix in license

* cleaning, linting

* spelling

* more spelling

* reno added

* Update qiskit/aqua/components/optimizers/aqgd.py

Co-authored-by: Steve Wood <[email protected]>

* Update qiskit/aqua/components/optimizers/aqgd.py

Co-authored-by: Steve Wood <[email protected]>

* code review

* updated release note aqgd

* code review 2

Co-authored-by: Anton Dekusar <[email protected]>
Co-authored-by: Anton Dekusar <[email protected]>
Co-authored-by: Steve Wood <[email protected]>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@woodsp-ibm woodsp-ibm woodsp-ibm approved these changes

@levbishop levbishop Awaiting requested review from levbishop

@manoelmarques manoelmarques Awaiting requested review from manoelmarques

@adekusar-drl adekusar-drl Awaiting requested review from adekusar-drl

@stefan-woerner stefan-woerner Awaiting requested review from stefan-woerner

Assignees
No one assigned
Labels
Changelog: New Feature Include in the Added section of the changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pbark @adekusar-drl @woodsp-ibm