Skip to content

Handle list of QuantumCircuit objects in job memory mapping#47

Merged
mtreinish merged 4 commits into
qiskit-community:masterfrom
lasys:fix-#46
Aug 19, 2021
Merged

Handle list of QuantumCircuit objects in job memory mapping#47
mtreinish merged 4 commits into
qiskit-community:masterfrom
lasys:fix-#46

Conversation

@lasys

@lasys lasys commented Aug 6, 2021

Copy link
Copy Markdown
Contributor

Summary

Fixes #46

Details and comments

set self.qobj to given QuantumCircuit

@lasys

lasys commented Aug 13, 2021

Copy link
Copy Markdown
Contributor Author

@mtreinish could you please review the PR? Thanks :)

@mtreinish mtreinish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pushing the PR. I think it will work, but I left an inline suggestion to make the intent a bit clearer.

Comment thread test/test_job.py Outdated
# pylint: disable=protected-access

import unittest
from unittest import mock

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this needed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test failed locally, so i added this.
If it doesn't fail on GitHub and/or your system, i can removed it.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's going to block CI, the lint rules block unused imports and nothing is using mock plain (it's only used as unittest.mock)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right. I removed it and ran tox, so hopefully the CI goes green.

Comment thread qiskit_aqt_provider/aqt_job.py Outdated
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>

@mtreinish mtreinish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing which would be good to have here is a test case for a job with a list of quantum circuits to verify the change works. Something like test_job_counts_measurement_mapping but passing [qc] to the fake job instead of using qc.

@lasys

lasys commented Aug 16, 2021

Copy link
Copy Markdown
Contributor Author

The other thing which would be good to have here is a test case for a job with a list of quantum circuits to verify the change works. Something like test_job_counts_measurement_mapping but passing [qc] to the fake job instead of using qc.

Good point. I will write one.

@mtreinish mtreinish left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for the quick updates and fixing this!

@mtreinish mtreinish changed the title Fix #46 Handle list of QuantumCircuit objects in job memory mapping Aug 19, 2021
@mtreinish mtreinish merged commit 5158e6b into qiskit-community:master Aug 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failure when running QAOA on AQT-Simulator

2 participants