Handle list of QuantumCircuit objects in job memory mapping#47
Conversation
|
@mtreinish could you please review the PR? Thanks :) |
mtreinish
left a comment
There was a problem hiding this comment.
Thanks for pushing the PR. I think it will work, but I left an inline suggestion to make the intent a bit clearer.
| # pylint: disable=protected-access | ||
|
|
||
| import unittest | ||
| from unittest import mock |
There was a problem hiding this comment.
The test failed locally, so i added this.
If it doesn't fail on GitHub and/or your system, i can removed it.
There was a problem hiding this comment.
It's going to block CI, the lint rules block unused imports and nothing is using mock plain (it's only used as unittest.mock)
There was a problem hiding this comment.
You're right. I removed it and ran tox, so hopefully the CI goes green.
Co-authored-by: Matthew Treinish <mtreinish@kortar.org>
mtreinish
left a comment
There was a problem hiding this comment.
The other thing which would be good to have here is a test case for a job with a list of quantum circuits to verify the change works. Something like test_job_counts_measurement_mapping but passing [qc] to the fake job instead of using qc.
Good point. I will write one. |
mtreinish
left a comment
There was a problem hiding this comment.
LGTM, thanks for the quick updates and fixing this!
Summary
Fixes #46
Details and comments
set
self.qobjto given QuantumCircuit