Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to control the use of ipv6 or ipv4 #83

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support to control the use of ipv6 or ipv4 #83

wants to merge 2 commits into from

Conversation

wangmq0719
Copy link
Collaborator

No description provided.

@@ -176,3 +181,29 @@ def is_sub_resource(self, key):
"replication", "append", "position", "cname"
]
return key in keys_map


def has_ipv6(host):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add unittests here please.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ping @wangmq0719 for this review.



def has_ipv6(host):
""" Returns True if the system resolves host to an IPv6 address by default. """
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Single line comment can use:

# Returns True if the system resolves host to an IPv6 address by default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants