Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: 默认值错误导致加载空节点 #2280

Merged
merged 9 commits into from
Aug 13, 2024
Merged

fix: 默认值错误导致加载空节点 #2280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4a0ae4f
fix: album.company显示问题
Younglina Mar 20, 2023
904fec5
fix: TrackListItem序号问题
Younglina Mar 23, 2023
7057057
Merge branch 'master' into master
Younglina Mar 23, 2023
ef1419a
Merge branch 'qier222:master' into master
Younglina Mar 6, 2024
be7cef9
fix: 手机号placeholder显示问题
Younglina Mar 6, 2024
8c732ce
fix: 手机号placeholder显示问题
Younglina Mar 6, 2024
a1390af
Merge branch 'master' of https://github.com/qier222/YesPlayMusic
actions-user Mar 18, 2024
159940d
fix: 默认值错误导致加载空节点
Younglina Jul 30, 2024
1a019e4
fix: 通过/artists接口获取的hotsongs没有图片了，改成通过id获取歌曲详情
Younglina Aug 5, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/CoverRow.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export default {
props: {
items: { type: Array, required: true },
type: { type: String, required: true },
subText: { type: String, default: 'null' },
subText: { type: String, default: 'none' },
pan93412 marked this conversation as resolved.
Show resolved Hide resolved
subTextFontSize: { type: String, default: '16px' },
showPlayCount: { type: Boolean, default: false },
columnNumber: { type: Number, default: 5 },
Expand Down
9 changes: 8 additions & 1 deletion src/views/artist.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -185,6 +185,7 @@ import {
followAArtist,
similarArtists,
} from '@/api/artist';
import { getTrackDetail } from '@/api/track';
import locale from '@/locale';
import { isAccountLoggedIn } from '@/utils/auth';
import NProgress from 'nprogress';
Expand Down Expand Up @@ -278,7 +279,7 @@ export default {
this.$parent.$refs.main.scrollTo({ top: 0 });
getArtist(id).then(data => {
this.artist = data.artist;
this.popularTracks = data.hotSongs;
this.setPopularTracks(data.hotSongs);
if (next !== undefined) next();
NProgress.done();
this.show = true;
Expand All @@ -295,6 +296,12 @@ export default {
this.similarArtists = data.artists;
});
},
setPopularTracks(hotSongs) {
const trackIDs = hotSongs.map(t => t.id);
getTrackDetail(trackIDs.join(',')).then(data => {
this.popularTracks = data.songs;
});
},
goToAlbum(id) {
this.$router.push({
name: 'album',
Expand Down