Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added screenshots for Examples section in graphical model - issue #7370 #8431

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

selmaVH1
Copy link
Collaborator

@selmaVH1 selmaVH1 commented Aug 10, 2023

fixes #7370 I have changed the key screenshots in this section to maintain consistency within the same operating system and added description for the Example section in graphical model.

Copy link
Member

@timlinux timlinux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @selmaVH1 Just one house keeping item - for the images you replaced with new images having new names, did you remove the old images if they are not being used anywhere?
image

@selmaVH1
Copy link
Collaborator Author

@timlinux no, I didn't, they are still in the folder. Just in case that new ones don't get approved. Should I remove old images?

@DelazJ
Copy link
Collaborator

DelazJ commented Aug 10, 2023

did you remove the old images if they are not being used anywhere?

👍🏿
@selmaVH1 And if possible, could you also use a more extended name instead of e.g. model_parameters_6 ( you did it in most of the places)

@selmaVH1
Copy link
Collaborator Author

@DelazJ sure, thanks for the suggestion.

@DelazJ
Copy link
Collaborator

DelazJ commented Aug 10, 2023

Just in case that new ones don't get approved. Should I remove old images?

Without the old images in the diff, it is hard to know what you are replacing, and whether better.

@selmaVH1
Copy link
Collaborator Author

Just in case that new ones don't get approved. Should I remove old images?

Without the old images in the diff, it is hard to know what you are replacing, and whether better.

@DelazJ I delete new images names and replace old images with new ones.

@DelazJ DelazJ merged commit a6dd1c1 into qgis:master Aug 23, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting Examples in graphical model help (Request in QGIS)
3 participants