Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix python requirements #8034

Closed
wants to merge 2 commits into from

Conversation

esnyder-rve
Copy link

Goal:
Fixes issue with docutils dependency on fresh builds. This also makes the python environment match
the website. I just pulled the REQUIREMENTS.txt from the QGIS-Website repo and added back the missing transifix-client that is missing from the website version and therefore was removed.

Ticket(s): #
fix #8024

  • Backport to LTR documentation is requested

Notes:
Some of the "deletions" are really just items being re-ordered. As stated above, the transifix-client item was the only one actually removed (and put back).

Copy link
Collaborator

@DelazJ DelazJ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @esnyder-rve

Fixes issue with docutils dependency on fresh builds

Afaics, this is no more the case, isn't it? A fresh build takes proper dependencies and I couldn't spot any regression regarding our concerns.

This also makes the python environment match the website.

I very much like getting latest versions and play with them but considering the recent report, I must admit that I couldn't find any reasonable arguments against your point (I secretly expected someone else would do but... 🥲 ). Let's however be minimalistic and not fetch everything from the website.

re transifex-client and sphinx[transifex], these are deprecated dependencies we should get rid of (they even result in warnings in build reports). QGIS-Documentation does not need them at the server level given that all the translation processes (config/pull/push/update) are currently done between Transifex and GitHub directly; the server "just" builds from strings in the repo. But we need to upgrade to the tx-cli before removal (I suspect our push action will fail next Tuesday)
Fix underway.

Comment on lines -1 to -2
# Memo: Should also be added to https://github.com/qgis/QGIS-Website/blob/master/REQUIREMENTS.txt
# for docker image builds
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep these lines, please? They are meant to help remember fixing the server dependencies when we add new ones to the docs

sphinx-intl[transifex]
icalendar
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove this one as we don't need/use it here

Suggested change
icalendar

sphinxext-rediraffe
sphinx_togglebutton
requests==2.25.1
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto

Suggested change
requests==2.25.1

@DelazJ
Copy link
Collaborator

DelazJ commented Feb 21, 2023

@esnyder-rve #8065 removed transifex dependency

@DelazJ
Copy link
Collaborator

DelazJ commented Mar 18, 2023

superseded by #8110

@DelazJ DelazJ closed this Mar 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Broken version of docutils doesn't render lists correctly
2 participants