Skip to content

fix(downloader): qdt_plugins_to_copy was not created in force mode#551

Merged
Guts merged 1 commit into
mainfrom
fix/plugins-downloader-with-force-mode-enabled
Sep 4, 2024
Merged

fix(downloader): qdt_plugins_to_copy was not created in force mode#551
Guts merged 1 commit into
mainfrom
fix/plugins-downloader-with-force-mode-enabled

Conversation

@Guts
Copy link
Copy Markdown
Collaborator

@Guts Guts commented Sep 4, 2024

When force: true in plugins downloader job, it was failing because of unbound locale var:

2024-09-04 10:03:43||ERROR||bouncer||exit_cli_error||43||cannot access local variable 'qdt_plugins_to_copy' where it 
is not associated with a value
Traceback (most recent call last):
  File "qgis_deployment_toolbelt\commands\deployment.py", line 207, in run
  File "qgis_deployment_toolbelt\jobs\job_plugins_downloader.py", line 120, in run
UnboundLocalError: cannot access local variable 'qdt_plugins_to_copy' where it is not associated with a value

@Guts Guts self-assigned this Sep 4, 2024
@Guts Guts added this to the 0.35.2 milestone Sep 4, 2024
@github-actions github-actions Bot added bug Something isn't working jobs Scenarios and jobs labels Sep 4, 2024
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Sep 4, 2024

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 70.52%. Comparing base (58ba890) to head (6724399).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...deployment_toolbelt/jobs/job_plugins_downloader.py 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
- Coverage   70.55%   70.52%   -0.03%     
==========================================
  Files          47       47              
  Lines        3124     3125       +1     
  Branches      669      669              
==========================================
  Hits         2204     2204              
- Misses        726      727       +1     
  Partials      194      194              
Flag Coverage Δ
unittests 69.95% <0.00%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...deployment_toolbelt/jobs/job_plugins_downloader.py 50.37% <0.00%> (-0.39%) ⬇️

@Guts Guts enabled auto-merge September 4, 2024 09:22
@Guts Guts merged commit d83f286 into main Sep 4, 2024
@Guts Guts deleted the fix/plugins-downloader-with-force-mode-enabled branch September 4, 2024 09:22
Guts added a commit that referenced this pull request Sep 4, 2024
Guts added a commit that referenced this pull request Oct 3, 2025
Updates the requirements on
[pytest-cov](https://github.com/pytest-dev/pytest-cov) to permit the
latest version.
<details>
<summary>Changelog</summary>
<p><em>Sourced from <a
href="https://github.com/pytest-dev/pytest-cov/blob/master/CHANGELOG.rst">pytest-cov's
changelog</a>.</em></p>
<blockquote>
<h2>7.0.0 (2025-09-09)</h2>
<ul>
<li>
<p>Dropped support for subprocesses measurement.</p>
<p>It was a feature added long time ago when coverage lacked a nice way
to measure subprocesses created in tests.
It relied on a <code>.pth</code> file, there was no way to opt-out and
it created bad interations
with <code>coverage's new patch system
&lt;https://coverage.readthedocs.io/en/latest/config.html#run-patch&gt;</code>_
added
in <code>7.10
&lt;https://coverage.readthedocs.io/en/7.10.6/changes.html#version-7-10-0-2025-07-24&gt;</code>_.</p>
<p>To migrate to this release you might need to enable the suprocess
patch, example for <code>.coveragerc</code>:</p>
<p>.. code-block:: ini</p>
<p>[run]
patch = subprocess</p>
<p>This release also requires at least coverage 7.10.6.</p>
</li>
<li>
<p>Switched packaging to have metadata completely in
<code>pyproject.toml</code> and use <code>hatchling
&lt;https://pypi.org/project/hatchling/&gt;</code>_ for
building.
Contributed by Ofek Lev in
<code>[#551](pytest-dev/pytest-cov#551)
&lt;https://github.com/pytest-dev/pytest-cov/pull/551&gt;</code>_
with some extras in
<code>[#716](pytest-dev/pytest-cov#716)
&lt;https://github.com/pytest-dev/pytest-cov/pull/716&gt;</code>_.</p>
</li>
<li>
<p>Removed some not really necessary testing deps like
<code>six</code>.</p>
</li>
</ul>
<h2>6.3.0 (2025-09-06)</h2>
<ul>
<li>Added support for markdown reports.
Contributed by Marcos Boger in
<code>[#712](pytest-dev/pytest-cov#712)
&lt;https://github.com/pytest-dev/pytest-cov/pull/712&gt;</code>_
and <code>[#714](pytest-dev/pytest-cov#714)
&lt;https://github.com/pytest-dev/pytest-cov/pull/714&gt;</code>_.</li>
<li>Fixed some formatting issues in docs.
Anonymous contribution in
<code>[#706](pytest-dev/pytest-cov#706)
&lt;https://github.com/pytest-dev/pytest-cov/pull/706&gt;</code>_.</li>
</ul>
<h2>6.2.1 (2025-06-12)</h2>
<ul>
<li>
<p>Added a version requirement for pytest's pluggy dependency (1.2.0,
released 2023-06-21) that has the required new-style hookwrapper
API.</p>
</li>
<li>
<p>Removed deprecated license classifier (packaging).</p>
</li>
<li>
<p>Disabled coverage warnings in two more situations where they have no
value:</p>
<ul>
<li>&quot;module-not-measured&quot; in workers</li>
<li>&quot;already-imported&quot; in subprocesses</li>
</ul>
</li>
</ul>
<h2>6.2.0 (2025-06-11)</h2>
<ul>
<li>
<p>The plugin now adds 3 rules in the filter warnings configuration to
prevent common coverage warnings being raised as obscure errors::</p>
<p>default:unclosed database in &lt;sqlite3.Connection object
at:ResourceWarning
once::PytestCovWarning</p>
</li>
</ul>
<!-- raw HTML omitted -->
</blockquote>
<p>... (truncated)</p>
</details>
<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/224d8964caad90074a8cf6dc8720b8f70f31629b"><code>224d896</code></a>
Bump version: 6.3.0 → 7.0.0</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/73424e3999f865eac72e27f09d5fe11b9703cfd6"><code>73424e3</code></a>
Cleanup the docs a bit.</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/36f1cc2967831dbd4c8aa70086fc86dc495f8b9a"><code>36f1cc2</code></a>
Bump pins in template.</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/f299c590a63a48e51e3ae949993dc7bb1f1d480d"><code>f299c59</code></a>
Bump the github-actions group with 2 updates</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/25f0b2e0cdbc345c0d3e49170f7a328c3e0d805f"><code>25f0b2e</code></a>
Update docs/config.rst</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/bb23eacc5531fb8f499213d8420407e0d72f88e3"><code>bb23eac</code></a>
Improve configuration docs</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/a19531e91e1ab753ccf648a2d9bab08a6fddebb9"><code>a19531e</code></a>
Switch from build/pre-commit to uv/prek - this should make this
faster.</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/82f999391073f2fb8ae422af452602f310086a2a"><code>82f9993</code></a>
Update changelog.</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/211b5cd41c29916bc643b4a11b00578ba4fd6fe8"><code>211b5cd</code></a>
Fix links.</li>
<li><a
href="https://github.com/pytest-dev/pytest-cov/commit/97aadd74bcbc00a2078d240e8fe871dd62b83d80"><code>97aadd7</code></a>
Update some ci config, reformat and apply some lint fixes.</li>
<li>Additional commits viewable in <a
href="https://github.com/pytest-dev/pytest-cov/compare/v4.0.0...v7.0.0">compare
view</a></li>
</ul>
</details>
<br />


Dependabot will resolve any conflicts with this PR as long as you don't
alter it yourself. You can also trigger a rebase manually by commenting
`@dependabot rebase`.

[//]: # (dependabot-automerge-start)
[//]: # (dependabot-automerge-end)

---

<details>
<summary>Dependabot commands and options</summary>
<br />

You can trigger Dependabot actions by commenting on this PR:
- `@dependabot rebase` will rebase this PR
- `@dependabot recreate` will recreate this PR, overwriting any edits
that have been made to it
- `@dependabot merge` will merge this PR after your CI passes on it
- `@dependabot squash and merge` will squash and merge this PR after
your CI passes on it
- `@dependabot cancel merge` will cancel a previously requested merge
and block automerging
- `@dependabot reopen` will reopen this PR if it is closed
- `@dependabot close` will close this PR and stop Dependabot recreating
it. You can achieve the same result by closing it manually
- `@dependabot show <dependency name> ignore conditions` will show all
of the ignore conditions of the specified dependency
- `@dependabot ignore this major version` will close this PR and stop
Dependabot creating any more for this major version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this minor version` will close this PR and stop
Dependabot creating any more for this minor version (unless you reopen
the PR or upgrade to it yourself)
- `@dependabot ignore this dependency` will close this PR and stop
Dependabot creating any more for this dependency (unless you reopen the
PR or upgrade to it yourself)


</details>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working jobs Scenarios and jobs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants