Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

initialize_block enum #2150

Merged
merged 2 commits into from
Jul 17, 2024
Merged

initialize_block enum #2150

merged 2 commits into from
Jul 17, 2024

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Jul 8, 2024 •
edited
Loading

Referenced issues

Description of the Change

  • initialize_block returns ExtrinsicInclusionMode if Core version ≥ 5
    • ProposerImpl doesn't add extrinsics from TransactionPool if ExtrinsicInclusionMode::OnlyInherents

Possible Drawbacks

@turuslan
initialize_block enum
0799b7e 
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan requested review from xDimon and kamilsa July 8, 2024 08:02
@turuslan turuslan merged commit 05dcb04 into master Jul 17, 2024
12 of 14 checks passed
@turuslan turuslan deleted the feature/initialize-block-enum branch July 17, 2024 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xDimon xDimon xDimon approved these changes

@kamilsa kamilsa kamilsa approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Update Core::initialize_block
3 participants
@turuslan @xDimon @kamilsa