Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

grandpa cache votes db #1961

Merged
merged 10 commits into from
Feb 2, 2024
Merged

grandpa cache votes db #1961

merged 10 commits into from
Feb 2, 2024

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

  • prevent equivocation
    • save votes after signing new vote
    • load when creating round
  • deduplicate onPrevote/onPrecommit/update to VotingRoundUpdate

Benefits

Possible Drawbacks

@kamilsa kamilsa requested review from xDimon and kamilsa January 29, 2024 07:30
@turuslan turuslan requested a review from xDimon January 29, 2024 11:50
core/storage/predefined_keys.hpp Outdated Show resolved Hide resolved
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>

# Conflicts:
#	core/consensus/grandpa/impl/voting_round_impl.cpp
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan merged commit cfa9f65 into master Feb 2, 2024
12 of 13 checks passed
@turuslan turuslan deleted the grandpa/db-votes branch February 2, 2024 09:41
@turuslan turuslan mentioned this pull request May 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants