Refactor key types #1829
Merged
Refactor key types #1829
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xDimon
force-pushed
the
refactor/key_types
branch
from
8bc8463
to
26d68f9
Compare
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
xDimon
force-pushed
the
refactor/key_types
branch
from
26d68f9
to
2b86cd5
Compare
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
turuslan
approved these changes
Oct 6, 2023
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Harrm
reviewed
Oct 9, 2023
Comment on lines
68
to
75
| store_->generateEd25519Keypair(KeyTypes::GRANDPA, *dev).value(); | ||
| store_->generateSr25519Keypair(KeyTypes::BABE, *dev).value(); | ||
| store_->generateSr25519Keypair(KeyTypes::IM_ONLINE, *dev).value(); | ||
| store_->generateSr25519Keypair(KeyTypes::AUTHORITY_DISCOVERY, *dev) | ||
| .value(); | ||
| store_->generateSr25519Keypair(KeyTypes::KEY_TYPE_ASGN, *dev).value(); | ||
| store_->generateSr25519Keypair(KeyTypes::KEY_TYPE_PARA, *dev).value(); | ||
| store_->generateEcdsaKeypair(KeyTypes::BEEFY, *dev).value(); |
There was a problem hiding this comment.
Can't this be done with a list and a loop?
There was a problem hiding this comment.
Would need 3 loops, because of interface, for each crypto type
There was a problem hiding this comment.
Yes, it might, but it generated different crypto (Ed*, Sr*, Ecdsa) and different purposes. Simplifying with cycle does not seem simpler.
There was a problem hiding this comment.
There are five sr keys in a row, for example, this can be refactored to a loop. It's not necessary to make everything one loop.
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Harrm
approved these changes
Oct 9, 2023
|
|
||
| /** | ||
| * Types are 32bit integers, which represent encoded 4-char strings | ||
| * Makes 32bit integer uin which represent encoded 4-char strings |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
no specified
Description of the Change
Transparent conversion KeyType <-> KeyTypeId.
Literals for key (for human readability)
Benefits
Possible Drawbacks
Usage Examples or Tests
Alternate Designs