Feature/async-backing #1825

iceseer · 2023-10-05T07:07:12Z

Description of the Change

Async-backing implementation.
Set of minor fixes

Additionally

Validation protocol V1 is removed

Signed-off-by: iceseer <[email protected]>

move -> forward Signed-off-by: iceseer <[email protected]>

Signed-off-by: iceseer <[email protected]>

…ncoding Signed-off-by: iceseer <[email protected]> # Conflicts: # test/core/storage/trie_pruner/trie_pruner_test.cpp

Signed-off-by: iceseer <[email protected]>

This reverts commit 7ff93a3.

Signed-off-by: iceseer <[email protected]>

turuslan · 2024-02-15T09:17:53Z

core/network/impl/peer_manager_impl.cpp

+      auto validation_protocol = [&]() -> std::shared_ptr<ProtocolBase> {
+        if (proto_version == network::CollationVersion::VStaging) {
+          return router_->getValidationProtocolVStaging();
+        } else {
+          return router_->getValidationProtocol();
+        }
+      }();


Do you want to choose protocol supported by client,
or does runtime api return protocol version (e.g. async backing off/on)?

// may sort/reorder protocol list based on peer protocol list from "/identify" host.newStream({"/validation/2", "/validation/1"}, [](r) { if r.protocol == "/validation/1" protocol_1.onOutgoingStream(r.stream) if r.protocol == "/validation/2" protocol_2.onOutgoingStream(r.stream) })

kamilsa

Fix too many logs like:

24.02.19 04:50:00.089592  main_runner      Warning   ParachainProcessorImpl  After `send_peer_messages_for_relay_parent` no parachain state on relay_parent. (relay_parent=0x9ff1…b8ac)

and

24.02.19 04:50:06.074950  main_runner      Warning   PeerManager  Unable to create stream /e143f23803ac50e8f6f8e62695d1ce9e4e1d68aa36c1cd2cfd15340213f3423e/validation/1 with …uB1dLv: Stream: reset by remote peer

Signed-off-by: iceseer <[email protected]>

core/parachain/pvf/pvf_impl.cpp

core/utils/thread_pool.hpp

test/core/storage/trie_pruner/trie_pruner_test.cpp

zombienet/0001-parachains-smoke-test/0001-parachains-smoke-test.toml

test/core/parachain/pvf_test.cpp

test/core/blockchain/block_header_repository_test.cpp

core/parachain/validator/backing_implicit_view.cpp

…ng_net

core/utils/struct_to_tuple.hpp

core/application/impl/app_configuration_impl.hpp

core/consensus/babe/impl/babe.cpp

xDimon · 2024-02-15T13:49:55Z

core/network/impl/router_libp2p.cpp

+    //    app_state_manager_->takeControl(*collation_protocol_.get());
+    //    app_state_manager_->takeControl(*validation_protocol_.get());


Uncomment or remove

xDimon · 2024-02-19T13:52:36Z

core/primitives/math.hpp

@@ -36,6 +36,18 @@ namespace kagome::math {
    return res;
  }

+  template <typename T, typename E>
+  inline outcome::result<void> checked_sub(T &x, T y, E e) {
+    static_assert(std::numeric_limits<T>::is_integer


Suggested change

static_assert(std::numeric_limits<T>::is_integer

BOOST_STATIC_ASSERT(std::numeric_limits<T>::is_integer

BOOST_STATIC_ASSERT используется в 2 местах, а static_assert во всем остальном коде. Думаю логично переехать на static_assert

core/parachain/validator/impl/parachain_processor.cpp

xDimon · 2024-02-19T13:58:23Z

core/parachain/validator/impl/parachain_processor.cpp


-    protocol->request(peer_info, candidate_hash, std::forward<F>(callback));
+    /// TODO(iceseer): do


Is TODO actual? Add more details if do

https://imgur.com/9Rby94j.png 2-я строка

Signed-off-by: iceseer <[email protected]>

Signed-off-by: iceseer <[email protected]> # Conflicts: # core/network/impl/peer_manager_impl.cpp # core/parachain/validator/impl/parachain_processor.cpp

Signed-off-by: iceseer <[email protected]>

core/parachain/validator/backing_implicit_view.hpp

core/parachain/validator/collations.hpp

Signed-off-by: iceseer <[email protected]>

Signed-off-by: iceseer <[email protected]> # Conflicts: # core/network/impl/peer_manager_impl.cpp # core/parachain/validator/impl/parachain_processor.cpp

iceseer added 30 commits August 29, 2023 15:12

encoder

12ea9d1

Signed-off-by: iceseer <[email protected]>

scale master

7f506e2

Signed-off-by: iceseer <[email protected]>

repeat

bf9f63a

Signed-off-by: iceseer <[email protected]>

encode builded

0d29531

Signed-off-by: iceseer <[email protected]>

repeats

987c17e

Signed-off-by: iceseer <[email protected]>

formatting

ebafabd

Signed-off-by: iceseer <[email protected]>

formatting

51b8e7f

move -> forward Signed-off-by: iceseer <[email protected]>

1

6ebc47c

Signed-off-by: iceseer <[email protected]>

compact integer encoding

965dc29

Signed-off-by: iceseer <[email protected]>

encode bitvec

e5ce6db

Signed-off-by: iceseer <[email protected]>

encode variant

95f4925

Signed-off-by: iceseer <[email protected]>

encoding

8188619

Signed-off-by: iceseer <[email protected]>

test

40d3bef

Signed-off-by: iceseer <[email protected]>

Merge remote-tracking branch 'origin/master' into refactoring/scale_e…

ec390ee

…ncoding Signed-off-by: iceseer <[email protected]> # Conflicts: # test/core/storage/trie_pruner/trie_pruner_test.cpp

pair

e572d55

Signed-off-by: iceseer <[email protected]>

ptrs

43cb4c7

Signed-off-by: iceseer <[email protected]>

not works

fa4aea1

Signed-off-by: iceseer <[email protected]>

builded

2fc1b14

Signed-off-by: iceseer <[email protected]>

fixup

f1afa9a

Signed-off-by: iceseer <[email protected]>

tests + fixes

31136d0

Signed-off-by: iceseer <[email protected]>

ambigous call

738b65d

Signed-off-by: iceseer <[email protected]>

test

f7a0b32

Signed-off-by: iceseer <[email protected]>

1

b314340

Signed-off-by: iceseer <[email protected]>

tests

7b9b87a

Signed-off-by: iceseer <[email protected]>

tests + ref

48bd319

Signed-off-by: iceseer <[email protected]>

tests

cfd6150

Signed-off-by: iceseer <[email protected]>

tests

9e50a87

Signed-off-by: iceseer <[email protected]>

test

c614c23

Signed-off-by: iceseer <[email protected]>

test

69b7e3a

Signed-off-by: iceseer <[email protected]>

formatting

ca11bb0

Signed-off-by: iceseer <[email protected]>

iceseer added 4 commits February 14, 2024 13:55

Revert "revert libp2p to 0.1.17"

1831f4b

This reverts commit 7ff93a3.

building tests

6e48981

Signed-off-by: iceseer <[email protected]>

formatting

fc1a867

Signed-off-by: iceseer <[email protected]>

bitfield signature fixup

f4943fb

Signed-off-by: iceseer <[email protected]>

turuslan reviewed Feb 15, 2024

View reviewed changes

kamilsa reviewed Feb 19, 2024

View reviewed changes

iceseer added 2 commits February 19, 2024 10:14

revert trie pruner test

9c93ce1

Signed-off-by: iceseer <[email protected]>

less logs

38b6992

Signed-off-by: iceseer <[email protected]>

turuslan reviewed Feb 19, 2024

View reviewed changes

Merge remote-tracking branch 'origin/master' into feature/async_backi…

6c94d5d

…ng_net

xDimon reviewed Feb 19, 2024

View reviewed changes

qdrvm deleted a comment from iceseer Feb 22, 2024

iceseer force-pushed the feature/async_backing_net branch from f3945ec to 6f00882 Compare February 23, 2024 09:08

iceseer and others added 3 commits February 23, 2024 12:45

issues fixup

25739ba

Signed-off-by: iceseer <[email protected]>

issuse for todo

aeabf05

Signed-off-by: iceseer <[email protected]> # Conflicts: # core/network/impl/peer_manager_impl.cpp # core/parachain/validator/impl/parachain_processor.cpp

Fix build (missing outcome include)

8081fba

iceseer force-pushed the feature/async_backing_net branch 3 times, most recently from 4efbfdb to 0c4c0b7 Compare February 23, 2024 15:50

remove validation protocol v1

36658b6

Signed-off-by: iceseer <[email protected]>

iceseer force-pushed the feature/async_backing_net branch from 0c4c0b7 to 36658b6 Compare February 23, 2024 15:52

xDimon reviewed Feb 25, 2024

View reviewed changes

core/parachain/validator/backing_implicit_view.hpp Show resolved Hide resolved

core/parachain/validator/collations.hpp Show resolved Hide resolved

license

b30841e

Signed-off-by: iceseer <[email protected]>

iceseer requested review from xDimon and kamilsa February 26, 2024 06:35

xDimon approved these changes Feb 26, 2024

View reviewed changes

Merge branch 'master' into feature/async_backing_net

8cec9e8

Signed-off-by: iceseer <[email protected]> # Conflicts: # core/network/impl/peer_manager_impl.cpp # core/parachain/validator/impl/parachain_processor.cpp

kamilsa approved these changes Feb 27, 2024

View reviewed changes

iceseer merged commit 5183aa6 into master Feb 27, 2024
12 of 13 checks passed

iceseer deleted the feature/async_backing_net branch February 27, 2024 16:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feature/async-backing #1825

Feature/async-backing #1825

iceseer commented Oct 5, 2023 •

edited

Loading

turuslan Feb 15, 2024 •

edited

Loading

kamilsa left a comment

xDimon Feb 15, 2024

xDimon Feb 19, 2024

iceseer Feb 22, 2024

xDimon Feb 19, 2024

iceseer Feb 22, 2024

		// app_state_manager_->takeControl(*collation_protocol_.get());
		// app_state_manager_->takeControl(*validation_protocol_.get());

	static_assert(std::numeric_limits<T>::is_integer
	BOOST_STATIC_ASSERT(std::numeric_limits<T>::is_integer


		protocol->request(peer_info, candidate_hash, std::forward<F>(callback));
		/// TODO(iceseer): do

Feature/async-backing #1825

Feature/async-backing #1825

Conversation

iceseer commented Oct 5, 2023 • edited Loading

Description of the Change

Additionally

turuslan Feb 15, 2024 • edited Loading

Choose a reason for hiding this comment

kamilsa left a comment

Choose a reason for hiding this comment

xDimon Feb 15, 2024

Choose a reason for hiding this comment

xDimon Feb 19, 2024

Choose a reason for hiding this comment

iceseer Feb 22, 2024

Choose a reason for hiding this comment

xDimon Feb 19, 2024

Choose a reason for hiding this comment

iceseer Feb 22, 2024

Choose a reason for hiding this comment

iceseer commented Oct 5, 2023 •

edited

Loading

turuslan Feb 15, 2024 •

edited

Loading