New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor block production #1795

Merged

xDimon merged 40 commits into master from refactor/block_production

Oct 3, 2023

Member

xDimon commented Sep 6, 2023 •

edited

Loading

Referenced issues

Resolves #1598
Related with #1591 as preparation

Description of the Change

Separate block production consensus and mechanism of changing and processing slots and epochs.
Support of multi-consensuses and select needed basing parent block data.
Simplify and/or refactor some data and methods

Benefits

Ability to support several block production consensuses.
Base for developing SASSAFRAS.

Usage Examples or Tests

New tests have provided, existing tests have adapted.

xDimon added 26 commits

September 6, 2023 11:23


          fix for C++20: using aggregate ctors

9165b62

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          fix for C++20: replace deprecated std::is_pod

910a7ab

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          feature: interfaces production and finality consensuses

4a49e9f

feature: consensus selector

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          feature: timeline (of block production)

d967621

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: move time-meaning types from babe to up level (timeline)

2e1a4c6

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: move common production consensus types from babe to up leve…

3f05a46

…l (timeline)

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: move block-appending mechanisms from babe to up level (time…

d4f7660

…line)

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: move block-appending mechanisms from babe to up level (time…

ce71987

…line)

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: replace include-guard by pragma-once (for consensuses classes)

8eafc0e

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          fix: test build

18df53d

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: move consensus selection to timeline

5b7283b

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: extract application::AppConfiguration::SyncMethod to applic…

8187ab8

…ation::SyncMethod

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          feature: cacheable hash of block header

e3914f5

refactor: replace aggregating constructor call of block headers

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: simplify BabeLottery

1d19b99

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: extract consensus::babe::Babe::State to consensus::SyncStat…

43552b4

…e (and rename corresponding events)

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: change JustificationObserver from struct to class

5bc56c8

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: move babe_error.* to impl directory

03bb85c

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: add ProductionConsensus to base of Babe

376d5fc

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: register ConsensusSelector and Timeline in Injector

45e1649

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          update: extend Timeline interface

c56af85

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          update: inject Timeline to Application

943ae7a

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          draft

f5698a4

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          draft

2e93350

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          draft

392033f

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          fix: using of dangling references

5de5bb1

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: babe digests util

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>

xDimon requested review from kamilsa and turuslan

September 6, 2023 08:31

turuslan reviewed

View reviewed changes

core/primitives/block_header.hpp Outdated Show resolved Hide resolved

core/primitives/block_header.hpp Outdated Show resolved Hide resolved

core/consensus/timeline/impl/slots_util_impl.cpp Outdated Show resolved Hide resolved

core/consensus/timeline/impl/slots_util_impl.cpp Outdated Show resolved Hide resolved

core/consensus/timeline/impl/slots_util_impl.cpp Show resolved Hide resolved


          git: Merge branch 'master' into refactor/block_production

3166e96

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>

xDimon added 4 commits

September 18, 2023 11:53


          fix: code broken by merge

b906eb9

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          fix: review issues

5af144e

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          git: Merge branch 'master' into refactor/block_production

b2c0166

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          Merge branch 'master' into refactor/block_production

9c59495

kamilsa approved these changes

View reviewed changes

core/consensus/timeline/impl/timeline_impl.cpp Outdated Show resolved Hide resolved

core/consensus/production_consensus.hpp Show resolved Hide resolved

turuslan approved these changes

View reviewed changes

xDimon added 8 commits

September 30, 2023 00:37


          git: Merge branch 'master' into refactor/block_production

b799d88

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          git: Merge branch 'master' into refactor/block_production

cade7ce

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          fix: asan issues

df15e01

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          refactor: block header hash operations

112ecdd

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          git: Merge branch 'master' into refactor/block_production

850a6de

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          hotfix

645dc26

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          git: Merge branch 'master' into refactor/block_production

f8c0c46

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>


          fix: tests

ac4b5b9

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>

turuslan reviewed

View reviewed changes

core/consensus/babe/impl/babe.cpp Outdated Show resolved Hide resolved


          fix: missed thread for block proposing

7786ebf

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>

turuslan approved these changes

View reviewed changes

xDimon enabled auto-merge (squash)

October 3, 2023 07:26

xDimon merged commit 965aaf0 into master

7 of 10 checks passed

xDimon deleted the refactor/block_production branch

October 3, 2023 07:31

turuslan mentioned this pull request

beefy vote synchronized #1832

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet