-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fast pruner start #1756
Merged
Merged
Fast pruner start #1756
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
reviewed
Aug 24, 2023
…me into feature/fast-pruner-start
…me into feature/fast-pruner-start
turuslan
approved these changes
Aug 28, 2023
Codecov Report
@@ Coverage Diff @@
## master #1756 +/- ##
==========================================
- Coverage 21.71% 21.69% -0.02%
==========================================
Files 746 746
Lines 32085 32100 +15
Branches 16661 16672 +11
==========================================
- Hits 6966 6964 -2
- Misses 19306 19318 +12
- Partials 5813 5818 +5
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
iceseer
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Pruner starts immediately at a cost of no longer pruning the nodes already in storage at the time of the node startup (because without the long full state ref counting the pruner has no idea whether it can prune them or they are a part of the current state). CLI option --enable-thorough-pruning turns the old behaviour on (long startup, slightly better pruning).
Benefits
The node starts immediately.
Possible Drawbacks
Less effective pruning.
Alternate Designs
Asynchronous reference counting (and pruning overall) -- can be implemented in the future, but it's more complicated and with the reference counting taking half an hour on HDDs doesn't seem like a complete fix.
Persistent pruner state -- can be implemented in future, but it's more complicated and currently there's no clear vision how to do it.