Cache of runtime call results #1680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
feature: method erase for force proactive removal Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
…icate Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
xDimon
force-pushed
the
feature/runtime_call_results_cache
branch
from
2c0572b
to
38e8124
Compare
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
igor-egorov
approved these changes
Jul 14, 2023
| inline LockGuard(const Lockable<IsLockable> &) {} | ||
| }; | ||
|
|
||
| template <template <bool> class Lockable> |
There was a problem hiding this comment.
Please consider using SafeObject https://github.com/soramitsu/kagome/blob/master/core/utils/safe_object.hpp
There was a problem hiding this comment.
This solution selected for ability switch between thread-safe implementation and non-ts.
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Harrm
approved these changes
Jul 24, 2023
xDimon
added a commit
that referenced
this pull request
Jul 31, 2023
* feature: auto removal of non pruned forks * refactor: move SmallLruCache * refactor: get-or-calculate-and-put in LRU cache * refactor: add eq-operator for some types * feature: cache results of authority discovery api calls * feature: cache results of babe api calls * feature: cache results of grandpa api calls * feature: cache results of core and metadata apis calls * feature: cache results of parachain host calls * refactor: lru returns only optional sptr to value for safety * feature: method erase for force proactive removal * fix: follow actual lru interface * feature: method erase_if for force proactive removal by provided predicate * feature: prune parachain host caches by finalization * fix: optional using backward * fix: tests Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> --------- Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]> (cherry picked from commit b6900de)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Resolves #1673
Description of the Change
Store in memory idempotent api-calls results
Benefits
Accelerate by voiding some heavy runtime api calls