babe indexer #1661
Merged
babe indexer #1661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Harrm
reviewed
Jun 22, 2023
…inalized already indexed Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Harrm
reviewed
Jun 22, 2023
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Harrm
reviewed
Jun 22, 2023
Signed-off-by: turuslan <[email protected]>
Harrm
reviewed
Jun 27, 2023
Harrm
approved these changes
Jun 27, 2023
Signed-off-by: turuslan <[email protected]>
kamilsa
approved these changes
Jul 7, 2023
iceseer
reviewed
Jul 11, 2023
| } | ||
|
|
||
| std::shared_ptr<blockchain::BlockTree> block_tree_; | ||
| mutable std::vector<primitives::BlockInfo> path_; |
There was a problem hiding this comment.
кажется, что std::deque тут будет лучше
There was a problem hiding this comment.
либо резервировать по высоте |to.num - start.num|
There was a problem hiding this comment.
Возможно дистанция может быть очень большой, имеет смысл ограничить глубину?
| std::shared_ptr<storage::BufferStorage> db_; | ||
| std::shared_ptr<blockchain::BlockTree> block_tree_; | ||
| primitives::BlockInfo last_finalized_indexed_; | ||
| std::map<primitives::BlockInfo, Indexed<T>> map_; |
There was a problem hiding this comment.
Возможно тут map<> не нужен, у нас в список элементы кладутся уже сортированными и правая часть(до финализации) непрерывкная. Можно организовать поиск за O(1) по индексу заместо O(log N) по мапе.
There was a problem hiding this comment.
- проверяем по индексу за O(1), если лежит то что искали, то ок - выходим. Лучший случай
- если не то что надо, то за O(log N) через lower_bound. Худший случай.
Signed-off-by: turuslan <[email protected]> # Conflicts: # core/consensus/babe/impl/babe_config_repository_impl.cpp # core/consensus/babe/impl/babe_impl.cpp # core/injector/application_injector.cpp # test/core/network/state_protocol_observer_test.cpp
Signed-off-by: turuslan <[email protected]>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Indexer.valuefor each chain in block from it's parents.Descentremembers unindexed blocks info.Indexed::inherit=truemeans block is indexed and value is in blockIndexed::prev.BabeConfigRepositoryto useIndexer.BabeIndexedValue::statefrom runtime for genesis and warp sync'ed blocks.BabeIndexedValue::config, because digest changing it is rare.BabeIndexedValue::next_statefromBabeIndexedValue::configand digests.BabeConfigRepository::readFromState(BlockInfo)toBabeConfigRepository::warp(BlockInfo).BabeConfigRepositorytoWarpSync.BabeDigestObserverfromDigestTracker.SCALE_TIE_ONLY(field1, field2, ...)macro.InMemoryCursor.MapCursor::seekReverse(prefix).getNextEpochDigesttoHasAuthoritySetChange.BlockTree::isFinalized(BlockInfo).BlockTree::hasDirectChain(BlockInfo, BlockInfo)stub.BlockHeader::parentInfo().Benefits
Possible Drawbacks
WarpSync::applyInnercall), or will miss digests for old blocks. (or special struct for warp sync blocks/gaps)