Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix forced change #1534

Merged
merged 9 commits into from
Mar 23, 2023
Merged

Fix forced change #1534

merged 9 commits into from
Mar 23, 2023

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Mar 22, 2023 •
edited
Loading

Referenced issues

Description of the Change

  • Allow westend block 198785 past round.
  • Select round by set id.
  • Remember included forced changes.
    • Apply forced change once.
    • Don't apply scheduled changes if forced.
  • Apply forced change immediately (when two forced changes had same "target" and "delay", "adjust" never applied "node.action" for first, so set id was off).

Benefits

  • Westend syncs.

Possible Drawbacks

@turuslan
westend past round
8597d13 
Signed-off-by: turuslan <[email protected]>
@turuslan
remove unused
58a3e7c 
Signed-off-by: turuslan <[email protected]>
@turuslan
select round by set id
53f1f7a 
Signed-off-by: turuslan <[email protected]>
@turuslan
print block number
725d2b3 
Signed-off-by: turuslan <[email protected]>
@turuslan
forced_digests
00aaf11 
Signed-off-by: turuslan <[email protected]>
@turuslan
ForcedChange
f1cc269 
Signed-off-by: turuslan <[email protected]>
@turuslan
fix test
0365888 
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan requested a review from Harrm March 22, 2023 08:47
@vikinatora vikinatora mentioned this pull request Mar 23, 2023
Closed
xDimon
xDimon approved these changes Mar 23, 2023
View reviewed changes
core/consensus/grandpa/impl/grandpa_impl.cpp Outdated Show resolved Hide resolved
@turuslan
disable warp sync error
c589382 
Signed-off-by: turuslan <[email protected]>
@turuslan
westend genesis
09c6651 
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan merged commit 9ca199f into master Mar 23, 2023
@turuslan turuslan deleted the fix/forced-change branch March 23, 2023 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Harrm Harrm Harrm approved these changes

@xDimon xDimon xDimon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@turuslan @xDimon @Harrm