storeBuffer optimization #1505
Merged
storeBuffer optimization #1505
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
reviewed
Mar 1, 2023
turuslan
reviewed
Mar 1, 2023
| @@ -296,4 +297,103 @@ namespace kagome::runtime::binaryen { | |||
| return callHostApiFunc<mf>(this_.host_api_.get(), arguments); | |||
| } | |||
|
|
|||
| void RuntimeExternalInterface::init(wasm::Module &wasm, | |||
| wasm::ModuleInstance &instance) { | |||
| memory.resize(wasm.memory.initial * wasm::Memory::kPageSize); | |||
There was a problem hiding this comment.
Should we fill it with zeroes?
There was a problem hiding this comment.
По идее нет. init вызывается для объекта 1 раз в ModuleInstanceBase::ctor(). При ресайзе, память свыше memory.size() будет проинициализирована нулями, потому что default-inserted для интегральных типов 0. Т.е. на первом вызове это будет аллокация буффера проинициализированного нулями. Судя по коду не предполагается использовать объект RuntimeExternalInterface::memory до вызова init. Так что тут скорее вопросы к resize в ctor.
turuslan
reviewed
Mar 1, 2023
turuslan
approved these changes
Mar 1, 2023
Harrm
approved these changes
Mar 2, 2023
iceseer
force-pushed
the
fix/optimizations
branch
4 times, most recently
from
61772ba
to
9734e1e
Compare
iceseer
force-pushed
the
fix/optimizations
branch
from
9734e1e
to
e01a82f
Compare
Signed-off-by: iceseer <[email protected]>
iceseer
force-pushed
the
fix/optimizations
branch
from
e01a82f
to
7f8a3a6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the Change
Remove looped set of value into memory buffer.