Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Soralog error code #1417

Merged
merged 4 commits into from
Dec 3, 2022
Merged

Soralog error code #1417

merged 4 commits into from
Dec 3, 2022

Conversation

turuslan
Copy link
Contributor

Referenced issues

Description of the Change

Implemented formatter for outcome to use them directly: SL_DEBUG(log, "Error: {}", res.error()); (without .message()).

Benefits

Simplify review and reduce size of #1410

Possible Drawbacks

@turuslan turuslan force-pushed the split/pr-1410-soralog branch 2 times, most recently from 586c6f0 to ea5b9f6 Compare November 22, 2022 14:21
@codecov
Copy link

codecov bot commented Nov 22, 2022

Codecov Report

Merging #1417 (e5bb348) into master (2b6d360) will decrease coverage by 24.31%.
The diff coverage is 0.00%.

❗ Current head e5bb348 differs from pull request most recent head 729fb2a. Consider uploading reports for the commit 729fb2a to get more accurate results

@@            Coverage Diff             @@
##           master   #1417       +/-   ##
==========================================
- Coverage   24.31%   0.00%   -24.32%     
==========================================
  Files         643     634        -9     
  Lines       24260   23888      -372     
  Branches    12577   12380      -197     
==========================================
- Hits         5899       0     -5899     
- Misses      13096   23888    +10792     
+ Partials     5265       0     -5265     
Impacted Files Coverage Δ
core/api/service/impl/api_service_impl.cpp 0.00% <0.00%> (-13.47%) ⬇️
core/api/service/system/requests/peers.hpp 0.00% <0.00%> (ø)
core/api/transport/impl/http/http_session.cpp 0.00% <0.00%> (-43.08%) ⬇️
core/api/transport/impl/ws/ws_session.cpp 0.00% <0.00%> (-42.06%) ⬇️
core/application/impl/app_configuration_impl.cpp 0.00% <0.00%> (-24.18%) ⬇️
core/application/impl/kagome_application_impl.cpp 0.00% <0.00%> (ø)
...ore/authorship/impl/block_builder_factory_impl.cpp 0.00% <0.00%> (-50.00%) ⬇️
core/authorship/impl/block_builder_impl.cpp 0.00% <0.00%> (-25.81%) ⬇️
core/authorship/impl/proposer_impl.cpp 0.00% <0.00%> (-43.91%) ⬇️
core/blockchain/impl/block_storage_impl.cpp 0.00% <0.00%> (-22.81%) ⬇️
... and 549 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@turuslan turuslan force-pushed the split/pr-1410-soralog branch 8 times, most recently from d702108 to a20fdd1 Compare November 25, 2022 18:05
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan requested a review from xDimon December 2, 2022 12:05
@turuslan turuslan merged commit 21efc6c into master Dec 3, 2022
@turuslan turuslan deleted the split/pr-1410-soralog branch December 3, 2022 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants