-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Soralog error code #1417
Merged
Merged
Soralog error code #1417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
turuslan
force-pushed
the
split/pr-1410-soralog
branch
2 times, most recently
from
November 22, 2022 14:21
586c6f0
to
ea5b9f6
Compare
Codecov Report
@@ Coverage Diff @@
## master #1417 +/- ##
==========================================
- Coverage 24.31% 0.00% -24.32%
==========================================
Files 643 634 -9
Lines 24260 23888 -372
Branches 12577 12380 -197
==========================================
- Hits 5899 0 -5899
- Misses 13096 23888 +10792
+ Partials 5265 0 -5265
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
turuslan
force-pushed
the
split/pr-1410-soralog
branch
8 times, most recently
from
November 25, 2022 18:05
d702108
to
a20fdd1
Compare
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
turuslan
force-pushed
the
split/pr-1410-soralog
branch
from
December 2, 2022 07:23
a20fdd1
to
ce36cdf
Compare
igor-egorov
approved these changes
Dec 2, 2022
xDimon
requested changes
Dec 2, 2022
xDimon
approved these changes
Dec 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Description of the Change
Implemented formatter for outcome to use them directly:
SL_DEBUG(log, "Error: {}", res.error());
(without.message()
).Benefits
Simplify review and reduce size of #1410
Possible Drawbacks