-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
parachain pvf #1383
Merged
Merged
parachain pvf #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: turuslan <[email protected]>
Harrm
reviewed
Oct 31, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't quite get the part about RuntimeInstancePool in the drawbacks.
Signed-off-by: turuslan <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1383 +/- ##
==========================================
- Coverage 24.42% 24.32% -0.10%
==========================================
Files 641 643 +2
Lines 24148 24251 +103
Branches 12520 12573 +53
==========================================
+ Hits 5899 5900 +1
- Misses 12986 13085 +99
- Partials 5263 5266 +3
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
kamilsa
approved these changes
Nov 14, 2022
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Signed-off-by: turuslan <[email protected]>
Harrm
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Closes PoV execution and validation #1386
Description of the Change
Validate PoV with WASM (https://github.com/paritytech/polkadot/blob/master/node/core/candidate-validation/src/lib.rs)
Benefits
Possible Drawbacks
RuntimeInstancePool
instantiate when module is evicted.RuntimeInstancePool
instance list into module lru.RuntimeInstancePool
constructor.