Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

parachain pvf #1383

Merged
merged 13 commits into from
Nov 18, 2022
Merged

parachain pvf #1383

merged 13 commits into from
Nov 18, 2022

Conversation

turuslan
Copy link
Contributor

@turuslan turuslan commented Oct 31, 2022

Referenced issues

Description of the Change

Validate PoV with WASM (https://github.com/paritytech/polkadot/blob/master/node/core/candidate-validation/src/lib.rs)

Benefits

  • can validate parachain block

Possible Drawbacks

  • fix RuntimeInstancePool instantiate when module is evicted.
  • move RuntimeInstancePool instance list into module lru.
  • Pass lru size in RuntimeInstancePool constructor.

Signed-off-by: turuslan <[email protected]>
Copy link
Contributor

@Harrm Harrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't quite get the part about RuntimeInstancePool in the drawbacks.

core/network/types/collator_messages.hpp Outdated Show resolved Hide resolved
core/network/types/collator_messages.hpp Outdated Show resolved Hide resolved
core/parachain/pvf/pvf.hpp Outdated Show resolved Hide resolved
core/parachain/pvf/pvf_impl.cpp Outdated Show resolved Hide resolved
core/parachain/pvf/pvf_impl.cpp Show resolved Hide resolved
core/parachain/pvf/pvf_impl.cpp Outdated Show resolved Hide resolved
core/parachain/pvf/pvf_impl.cpp Outdated Show resolved Hide resolved
core/parachain/pvf/pvf_impl.cpp Show resolved Hide resolved
Signed-off-by: turuslan <[email protected]>
@turuslan turuslan requested a review from Harrm November 1, 2022 08:10
@codecov
Copy link

codecov bot commented Nov 1, 2022

Codecov Report

Merging #1383 (3af955e) into master (96ab3f7) will decrease coverage by 0.09%.
The diff coverage is 0.86%.

@@            Coverage Diff             @@
##           master    #1383      +/-   ##
==========================================
- Coverage   24.42%   24.32%   -0.10%     
==========================================
  Files         641      643       +2     
  Lines       24148    24251     +103     
  Branches    12520    12573      +53     
==========================================
+ Hits         5899     5900       +1     
- Misses      12986    13085      +99     
- Partials     5263     5266       +3     
Impacted Files Coverage Δ
core/common/visitor.hpp 58.33% <ø> (ø)
core/network/types/collator_messages.hpp 0.00% <0.00%> (ø)
core/parachain/pvf/pvf.hpp 0.00% <0.00%> (ø)
core/parachain/pvf/pvf_impl.cpp 0.00% <0.00%> (ø)
core/runtime/runtime_api/impl/parachain_host.cpp 0.00% <0.00%> (ø)
...me/runtime_api/impl/parachain_host_types_serde.cpp 0.00% <ø> (ø)
core/runtime/runtime_api/parachain_host.hpp 0.00% <ø> (ø)
core/injector/application_injector.cpp 39.79% <100.00%> (-0.09%) ⬇️
core/api/service/impl/api_service_impl.cpp 13.46% <0.00%> (-1.02%) ⬇️
core/metrics/impl/prometheus/handler_impl.cpp 28.57% <0.00%> (+2.04%) ⬆️
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@turuslan turuslan requested review from kamilsa and removed request for Harrm November 2, 2022 07:19
@turuslan turuslan merged commit 74d5c47 into master Nov 18, 2022
@turuslan turuslan deleted the feature/pvf branch November 18, 2022 09:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PoV execution and validation
3 participants