Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed 'to' field from block request #1371

Merged
merged 1 commit into from
Oct 20, 2022
Merged

Removed 'to' field from block request #1371

merged 1 commit into from
Oct 20, 2022

Conversation

xDimon
Copy link
Member

@xDimon xDimon commented Oct 20, 2022

Signed-off-by: Dmitriy Khaustov aka xDimon [email protected]

Referenced issues

Resolves #1365

Description of the Change

Removed 'to' field from block request

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
@xDimon xDimon enabled auto-merge (squash) October 20, 2022 07:19
@codecov
Copy link

codecov bot commented Oct 20, 2022

Codecov Report

Merging #1371 (6379e55) into master (58b2272) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #1371      +/-   ##
==========================================
- Coverage   24.16%   24.16%   -0.01%     
==========================================
  Files         627      627              
  Lines       23459    23447      -12     
  Branches    12262    12252      -10     
==========================================
- Hits         5669     5665       -4     
+ Misses      12515    12513       -2     
+ Partials     5275     5269       -6     
Impacted Files Coverage Δ
core/network/adapters/protobuf_block_request.hpp 31.11% <ø> (+1.11%) ⬆️
core/network/impl/protocols/sync_protocol_impl.cpp 8.75% <ø> (+0.14%) ⬆️
core/network/impl/synchronizer_impl.cpp 5.91% <ø> (ø)
core/network/types/blocks_request.hpp 69.23% <ø> (+6.73%) ⬆️
core/api/transport/impl/ws/ws_listener_impl.cpp 40.27% <0.00%> (-2.78%) ⬇️
core/application/impl/app_state_manager_impl.cpp 59.81% <0.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@xDimon xDimon requested a review from turuslan October 20, 2022 09:10
@xDimon xDimon merged commit 8781526 into master Oct 20, 2022
@xDimon xDimon deleted the update/block_request branch October 20, 2022 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove "to" from BlockRequest
3 participants