-
Notifications
You must be signed in to change notification settings - Fork 39
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Babe config repository #1354
Merged
Babe config repository #1354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #1354 +/- ##
==========================================
+ Coverage 24.39% 24.40% +0.01%
==========================================
Files 619 621 +2
Lines 23038 23062 +24
Branches 12021 12030 +9
==========================================
+ Hits 5619 5629 +10
+ Misses 12231 12226 -5
- Partials 5188 5207 +19
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
igor-egorov
approved these changes
Sep 29, 2022
turuslan
approved these changes
Sep 29, 2022
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referenced issues
Resolves #1345
Description of the Change
Implemented using of babe config over babe config repository. As result babe config is obtaining on demand. Config from last finalized block (from genesis in some cases) is using. It helps to avoid crash if runtime inaccessible for target block.
Benefits
No crash in that exceptional cases.
Possible Drawbacks
Sometimes might be done one extra wasm compilation.
Usage Examples or Tests
Existing tests is adapted.