Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Babe config repository #1354

Merged
merged 7 commits into from
Sep 29, 2022
Merged

Babe config repository #1354

merged 7 commits into from
Sep 29, 2022

Conversation

xDimon
Copy link
Member

@xDimon xDimon commented Sep 29, 2022

Referenced issues

Resolves #1345

Description of the Change

Implemented using of babe config over babe config repository. As result babe config is obtaining on demand. Config from last finalized block (from genesis in some cases) is using. It helps to avoid crash if runtime inaccessible for target block.

Benefits

No crash in that exceptional cases.

Possible Drawbacks

Sometimes might be done one extra wasm compilation.

Usage Examples or Tests

Existing tests is adapted.

Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
@xDimon xDimon requested review from kamilsa and turuslan September 29, 2022 08:10
@codecov
Copy link

codecov bot commented Sep 29, 2022

Codecov Report

Merging #1354 (6340a35) into master (610d964) will increase coverage by 0.01%.
The diff coverage is 28.00%.

@@            Coverage Diff             @@
##           master    #1354      +/-   ##
==========================================
+ Coverage   24.39%   24.40%   +0.01%     
==========================================
  Files         619      621       +2     
  Lines       23038    23062      +24     
  Branches    12021    12030       +9     
==========================================
+ Hits         5619     5629      +10     
+ Misses      12231    12226       -5     
- Partials     5188     5207      +19     
Impacted Files Coverage Δ
core/blockchain/impl/block_storage_impl.cpp 22.80% <ø> (+0.58%) ⬆️
core/blockchain/impl/block_tree_impl.hpp 33.33% <ø> (ø)
core/consensus/babe/impl/babe_impl.hpp 100.00% <ø> (ø)
core/consensus/babe/impl/babe_lottery_impl.cpp 28.57% <0.00%> (ø)
core/consensus/validation/babe_block_validator.hpp 100.00% <ø> (ø)
core/consensus/babe/impl/babe_util_impl.cpp 13.72% <17.64%> (-0.57%) ⬇️
core/blockchain/impl/block_tree_impl.cpp 21.19% <18.75%> (-0.27%) ⬇️
core/consensus/babe/impl/block_appender_impl.cpp 7.19% <25.00%> (-0.06%) ⬇️
core/consensus/babe/impl/babe_impl.cpp 14.05% <26.66%> (+0.03%) ⬆️
core/consensus/validation/babe_block_validator.cpp 34.78% <28.57%> (-1.59%) ⬇️
... and 10 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

core/injector/application_injector.cpp Outdated Show resolved Hide resolved
core/injector/application_injector.cpp Outdated Show resolved Hide resolved
core/injector/application_injector.cpp Outdated Show resolved Hide resolved
Signed-off-by: Dmitriy Khaustov aka xDimon <[email protected]>
@xDimon xDimon enabled auto-merge (squash) September 29, 2022 15:06
@xDimon xDimon merged commit 7a35947 into master Sep 29, 2022
@xDimon xDimon deleted the fix/crash branch September 29, 2022 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DB is getting corrupted on sync
3 participants