Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/req collation #1287

Merged
merged 14 commits into from
Aug 31, 2022
Merged

Feature/req collation #1287

merged 14 commits into from
Aug 31, 2022

Conversation

iceseer
Copy link
Contributor

@iceseer iceseer commented Jul 27, 2022 •
edited
Loading

Closes #1288

Changes

  • implements /polkadot/req_collation/1

    Future

    • candidate baking and /polkadot/validation/1 implementations
  • stores pending collations to PeerState for async processing.
  • getPeerState returns reference to PeerState -> avoids copying.
  • minor fixes and refactorings- implements request_response_protocol template

    Future:

    • implement notification_protocol template
    • base all existed protocols on these ones

@iceseer iceseer force-pushed the feature/req_collation branch from 5457d9a to b65bd97 Compare July 28, 2022 12:27
@iceseer iceseer marked this pull request as ready for review August 4, 2022 19:20
@iceseer iceseer requested review from igor-egorov and ortyomka August 5, 2022 08:09
@iceseer iceseer force-pushed the feature/req_collation branch from 3ee0026 to 0ff6c69 Compare August 7, 2022 15:17
iceseer added 2 commits August 7, 2022 18:29
@iceseer
parachain
5a79bb2 
Signed-off-by: iceseer <[email protected]>
@iceseer
Revert "Auxiliary commit to revert individual files from 5a79bb2"
20eb8de 
This reverts commit a060260f4c933aa18eaa40e1be3b436fa96bb963.

Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/req_collation branch from 0ff6c69 to 20eb8de Compare August 7, 2022 15:37
@iceseer
build
37b6683 
Signed-off-by: iceseer <[email protected]>
@codecov
Copy link

codecov bot commented Aug 7, 2022 •
edited
Loading

Codecov Report

Merging #1287 (c09824f) into master (d5709d6) will decrease coverage by 0.39%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master    #1287      +/-   ##
==========================================
- Coverage   25.69%   25.29%   -0.40%     
==========================================
  Files         596      605       +9     
  Lines       21562    21902     +340     
  Branches    11198    11359     +161     
==========================================
  Hits         5540     5540              
- Misses      10902    11242     +340     
  Partials     5120     5120
Impacted Files Coverage Δ
core/api/service/system/requests/peers.hpp 0.00% <0.00%> (ø)
core/application/impl/kagome_application_impl.cpp 0.00% <0.00%> (ø)
core/application/impl/kagome_application_impl.hpp 0.00% <ø> (ø)
core/consensus/babe/types/epoch_descriptor.hpp 0.00% <ø> (ø)
core/consensus/babe/types/epoch_digest.hpp 0.00% <ø> (ø)
core/consensus/grandpa/impl/grandpa_impl.cpp 2.74% <0.00%> (ø)
core/crypto/sr25519_types.hpp 25.00% <ø> (ø)
core/injector/application_injector.cpp 33.22% <0.00%> (-1.22%) ⬇️
core/network/collation_observer.hpp 0.00% <ø> (ø)
core/network/impl/peer_manager_impl.cpp 3.17% <0.00%> (-0.29%) ⬇️
... and 42 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@iceseer iceseer force-pushed the feature/req_collation branch from 9cfeb70 to 45cdbe9 Compare August 7, 2022 18:16
@iceseer
build fix
b00afc6 
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/req_collation branch from 45cdbe9 to b00afc6 Compare August 8, 2022 08:12
@kamilsa kamilsa requested review from turuslan and removed request for igor-egorov August 10, 2022 09:27
iceseer added 6 commits August 30, 2022 12:50
@iceseer
Merge remote-tracking branch 'origin/master' into feature/req_collation
8bb1771 
Signed-off-by: iceseer <[email protected]>

# Conflicts:
#	core/injector/CMakeLists.txt
#	core/network/common.hpp
#	core/network/impl/protocols/collation_protocol.cpp
#	core/network/protocol_base.hpp
#	core/network/types/collator_messages.hpp
@iceseer
ref
97e8cfe 
Signed-off-by: iceseer <[email protected]>
@iceseer
formatting
2e7e584 
Signed-off-by: iceseer <[email protected]>
@iceseer
ref + fixes
fd0be4c 
Signed-off-by: iceseer <[email protected]>
@iceseer
formatting
4dee86b 
Signed-off-by: iceseer <[email protected]>
@iceseer
build fix
1352db3 
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer requested a review from turuslan August 30, 2022 14:25
iceseer added 2 commits August 30, 2022 17:36
@iceseer
build fix
848fe75 
Signed-off-by: iceseer <[email protected]>
@iceseer
tests fix
e2696a0 
Signed-off-by: iceseer <[email protected]>
turuslan
turuslan requested changes Aug 31, 2022
View reviewed changes
Copy link
Contributor

@turuslan turuslan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more. 

Collation Advertise
-  para_hash
+  relay_parent

destructors were default and didn't override

@iceseer iceseer requested a review from turuslan August 31, 2022 07:39
@iceseer
issues fixes
c09824f 
Signed-off-by: iceseer <[email protected]>
@iceseer iceseer force-pushed the feature/req_collation branch from 5ef96a1 to c09824f Compare August 31, 2022 07:47
@iceseer iceseer merged commit 8d57222 into master Aug 31, 2022
@iceseer iceseer deleted the feature/req_collation branch August 31, 2022 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@turuslan turuslan turuslan approved these changes

@ortyomka ortyomka ortyomka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Request collation protocol
3 participants
@iceseer @turuslan @ortyomka