Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(firewall): delete chain rules by line number #2411

Merged
merged 4 commits into from
Aug 17, 2024

Conversation

qdm12
Copy link
Owner

@qdm12 qdm12 commented Aug 14, 2024

Image is with tag :pr-2411. It now deletes iptables rules by line number to go around iptables not finding existing rules for deletion, fixing #2334

  • Initial implementation
  • Some unit tests here and there
  • Self-tested locally
  • Feedback received

internal/firewall/delete.go Outdated Show resolved Hide resolved
@qdm12 qdm12 force-pushed the iptables-delete-num-2234 branch from 2ea501b to 3d41cc1 Compare August 17, 2024 10:12
@qdm12 qdm12 merged commit bc55c25 into master Aug 17, 2024
3 checks passed
@qdm12 qdm12 deleted the iptables-delete-num-2234 branch August 17, 2024 18:12
jfroy pushed a commit to jfroy/gluetun that referenced this pull request Aug 18, 2024
- Fix qdm12#2334 
- Parsing of iptables chains, contributing to progress for qdm12#1856
qdm12 added a commit that referenced this pull request Sep 29, 2024
- Fix #2334
- Parsing of iptables chains, contributing to progress for #1856
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant