Fix #4446: ✨ Added support for up and down arrow key movement in the year picker #19
+154
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… of the date picker - Prevent the default scroll movement when the arrow key is pressed Closes Hacker0x01#4446
balajis-qb
force-pushed
the
issue-4446/fix/support-up-down-key-navigation-for-year-picker
branch
from
8a1ae17
to
01dbc14
Compare
balajis-qb
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Linked issue: Hacker0x01#4446
Problem
The Year Picker doesn't support the up and down key navigation like the month picker and the date picker.
Changes
This PR adds support for updating the selected year in the year picker using the up and down arrow keys. It also blocks the default page movement on the press of arrow keys.
Contribution checklist