Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support removing tracker from all torrents in WebUI/WebAPI #21056

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Support removing tracker from all torrents in WebUI/WebAPI #21056

wants to merge 2 commits into from
+132 −8

Conversation

Piccirello
Copy link
Member

Closes #20661.

@Piccirello Piccirello added WebUI WebUI-related issues/changes WebAPI WebAPI-related issues/changes labels Jul 11, 2024
@Piccirello Piccirello requested a review from a team July 11, 2024 20:08
Chocobo1
Chocobo1 reviewed Jul 12, 2024
View reviewed changes
src/webui/www/private/confirmtrackerdeletion.html Outdated Show resolved Hide resolved
src/webui/www/private/scripts/client.js Outdated Show resolved Hide resolved
src/webui/api/torrentscontroller.cpp Outdated Show resolved Hide resolved
src/webui/api/torrentscontroller.cpp Outdated Show resolved Hide resolved
@Piccirello Piccirello mentioned this pull request Jul 15, 2024
Merged
@Piccirello Piccirello requested a review from Chocobo1 July 15, 2024 21:14
@Piccirello Piccirello force-pushed the remove-tracker branch 2 times, most recently from a82d621 to 88c84be Compare July 24, 2024 06:11
@Chocobo1 Chocobo1 requested a review from a team July 26, 2024 13:47
@thalieht
Copy link
Contributor

2

@Chocobo1 Chocobo1 mentioned this pull request Jul 29, 2024
Closed
Chocobo1
Chocobo1 previously approved these changes Aug 2, 2024
View reviewed changes
@Chocobo1 Chocobo1 added this to the 5.1 milestone Aug 2, 2024
@Piccirello
Copy link
Member Author

@Chocobo1 just curious, why get this in 5.1 instead of 5.0?

@Chocobo1
Copy link
Member

Chocobo1 commented Aug 2, 2024 •
edited

@Chocobo1 just curious, why get this in 5.1 instead of 5.0?

AFAIK v5.0 is in 'bug fix only' stage. New feature goes into the next dev cycle (v5.1).

@Piccirello
Copy link
Member Author

@Chocobo1 just curious, why get this in 5.1 instead of 5.0?

AFAIK v5.0 is in 'bug fix only' stage. New feature goes into the next dev cycle (v5.1).

Is there somewhere I can follow along this discussion/decision making?

@Chocobo1
Copy link
Member

Chocobo1 commented Aug 2, 2024

Is there somewhere I can follow along this discussion/decision making?

It usually starts with a new git branch creation (v5.0) and backport PRs emerge. The core devs discuss about it internally.

@glassez
Copy link
Member

glassez commented Aug 3, 2024

AFAIK v5.0 is in 'bug fix only' stage.

This should take effect with the release of RC. We were merging the "soft" features between beta and RC, and since RC is still not released, we could merge similar changes in 5.0.
I leave it to your final decision.

@Chocobo1
Copy link
Member

Chocobo1 commented Aug 3, 2024

I leave it to your final decision.

I don't really have strong reason or preference for it. By default I'm leaning to v5.1 for everything.

Chocobo1 pushed a commit that referenced this pull request Aug 4, 2024
@Piccirello
Don't reannounce when removing tracker via WebAPI
66c1acb 
Discussion: #21056 (comment)

PR #21077.
brvphoenix pushed a commit to brvphoenix/qBittorrent that referenced this pull request Aug 4, 2024
@Piccirello @brvphoenix
Don't reannounce when removing tracker via WebAPI
223cd89 
Discussion: qbittorrent#21056 (comment)

PR qbittorrent#21077.
Chocobo1
Chocobo1 reviewed Aug 6, 2024
View reviewed changes
src/webui/api/torrentscontroller.cpp Outdated Show resolved Hide resolved
src/webui/api/torrentscontroller.cpp Outdated Show resolved Hide resolved
@Piccirello Piccirello mentioned this pull request Aug 6, 2024
Merged
@glassez glassez requested a review from a team August 10, 2024 11:19
thalieht
thalieht previously approved these changes Aug 10, 2024
View reviewed changes
@Piccirello Piccirello mentioned this pull request Aug 13, 2024
Merged
@skomerko
Copy link
Contributor

@Piccirello, could you also add this option?

image

@Piccirello
Copy link
Member Author

@Piccirello, could you also add this option?

image

I'm going to hold off for now but good future work.

@glassez glassez requested review from Chocobo1 and a team August 14, 2024 15:48
Chocobo1
Chocobo1 reviewed Aug 17, 2024
View reviewed changes
src/webui/api/torrentscontroller.cpp

const QStringList urls = params()[u"urls"_s].split(u'|');
torrent->removeTrackers(urls);
for (BitTorrent::Torrent *const torrent : asConst(BitTorrent::Session::instance()->torrents()))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (BitTorrent::Torrent *const torrent : asConst(BitTorrent::Session::instance()->torrents()))
for (BitTorrent::Torrent *const torrent : asConst(torrents))

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glassez glassez glassez left review comments

@Chocobo1 Chocobo1 Chocobo1 left review comments

@stalkerok stalkerok stalkerok left review comments

@qBittUser qBittUser qBittUser left review comments

@thalieht thalieht thalieht left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
WebAPI WebAPI-related issues/changes WebUI WebUI-related issues/changes
Projects
None yet
Milestone
5.1
Development

Successfully merging this pull request may close these issues.

Remove a tracker from all torrents.
7 participants
@Piccirello @thalieht @Chocobo1 @glassez @skomerko @stalkerok @qBittUser