Skip to content

GHA CI: Use macOS 11 runner image#15377

Closed
xavier2k6 wants to merge 1 commit into
qbittorrent:masterfrom
xavier2k6:CI_macOS_11_runner_image
Closed

GHA CI: Use macOS 11 runner image#15377
xavier2k6 wants to merge 1 commit into
qbittorrent:masterfrom
xavier2k6:CI_macOS_11_runner_image

Conversation

@xavier2k6
Copy link
Copy Markdown
Member

Use macOS 11 (Big Sur) runner image.

It has now been made generally available.

Ref.: https://github.blog/changelog/2021-08-16-github-actions-macos-11-big-sur-is-generally-available-on-github-hosted-runners/

Supersedes #15195

@xavier2k6 xavier2k6 added CI Issues/PRs related to CI OS: macOS Issues specific to macOS and removed OS: macOS Issues specific to macOS labels Aug 26, 2021
ci:
name: Build
runs-on: macos-10.15
runs-on: macos-11
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps we can be a little more aggressive and use macos-latest. The steps below are actually salvaged from travisci script and the details didn't change vastly.

Copy link
Copy Markdown
Member Author

@xavier2k6 xavier2k6 Aug 27, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My original idea was to make "ALL CI Environments" use xxx-latest reference:#15355 (comment)

I am awaiting feedback about release schedule & may adopt my original idea instead.....

(I believe they make most recent OS use xxx-latest a month after general availability) but as I said.....need confirmation/feedback.

@glassez
Copy link
Copy Markdown
Member

glassez commented Aug 27, 2021

Isn't there any downside to losing CI for macOS 10.15? Is macOS 11 supposed to replace previous macOS versions, so that we no longer care about it? Or does a successful build on macOS 11 mean that it will also be successfully built on previous macOS?

@glassez
Copy link
Copy Markdown
Member

glassez commented Aug 27, 2021

@xavier2k6
Commit message should also have GHA CI: prefix.

@xavier2k6
Copy link
Copy Markdown
Member Author

Isn't there any downside to losing CI for macOS 10.15?
Is macOS 11 supposed to replace previous macOS versions, so that we no longer care about it?
Or does a successful build on macOS 11 mean that it will also be successfully built on previous macOS?

Remember we are only changing the "hosted system" & not the "target" so although we may build using macOS-11 we are still targeting what is set in cmake etc which is macOS 10.15

We build on windows-2019 but our target OS is still windows 7+

@xavier2k6
Copy link
Copy Markdown
Member Author

I will mark as draft until I hear back about what the update policy is from github/actions side.

@xavier2k6 xavier2k6 marked this pull request as draft August 27, 2021 11:10
@glassez
Copy link
Copy Markdown
Member

glassez commented Aug 27, 2021

Remember we are only changing the "hosted system" & not the "target" so although we may build using macOS-11 we are still targeting what is set in cmake etc which is macOS 10.15

Well, but then what is the real advantage? Test whether the latest build tools are able to compile it?

@xavier2k6
Copy link
Copy Markdown
Member Author

Well, but then what is the real advantage? Test whether the latest build tools are able to compile it?

Yes, as well as having the latest SDK versions available for when we may change target OS to 11+

What advantage was/is there to use Ubuntu-20.04 over Ubuntu-18.04 or windows-2019 over windows-2016??

If we can change all CI's to latest we really won't have to care about this kind of thing in the future....it'll get changed automatically.

@xavier2k6
Copy link
Copy Markdown
Member Author

xavier2k6 commented Aug 27, 2021

Ok, I got some feedback from github/actions side:

Hello @xavier2k6 , usually it takes ~6 months.

Since macOS-11 was in private beta, the number of users and feedback was limited.
After GA, users has started to switch to the new OS. Before migrating -latest, we need to make sure that there is no any issues with the new image.
Another point is proper communication. We need to announce migrating latest tag beforehand because switching tag is always painful for users.

The switchover of the latest label to the most recent OS after general availability is ~6 months.

Would it be ok so @glassez @Chocobo1 @sledgehammer999 if I modify this PR or create a new one to change "ALL CI runner images" to use the xxx-latest label??

@Chocobo1
Copy link
Copy Markdown
Member

Would it be ok so @glassez @Chocobo1 @sledgehammer999 if I modify this PR or create a new one to change "ALL CI runner images" to use the xxx-latest label??

I'm fine with {windows, macos}-latest but I still hold the same opinion for ubuntu-latest: #15355 (comment)

@xavier2k6
Copy link
Copy Markdown
Member Author

FYI
For Ubuntu (only LTS) versions are used so -latest label on that system wouldn't be migrated to Ubuntu-22.04 until ~6 months after it became GA which would be around this time next year that the migration would occur.

github/actions only support 2 versions of GA OS's - we would have to move away from {Ubuntu-20.04, macOS-11 & windows-2019} at some stage in the future as these would become deprecated/removed.

We support at least 2 latest OS versions (LTS only for Ubuntu) and initiate deprecation process for the oldest one when image usage drops below 5%.

ref.: https://github.com/AlenaSviridenko/virtual-environments/blob/main/docs/software-and-images-guidelines.md#software-and-images-support-policy

-latest on all environments makes that transition convenient.

@xavier2k6
Copy link
Copy Markdown
Member Author

@Chocobo1 thoughts on #15377 (comment)?

@xavier2k6
Copy link
Copy Markdown
Member Author

Closing in favor of PR #15589

@xavier2k6 xavier2k6 closed this Oct 18, 2021
@xavier2k6 xavier2k6 deleted the CI_macOS_11_runner_image branch October 18, 2021 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI Issues/PRs related to CI OS: macOS Issues specific to macOS

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants