Skip to content

Accept v2 infohashes for download#15294

Merged
sledgehammer999 merged 1 commit into
qbittorrent:masterfrom
sledgehammer999:accept_v2_infohash
Aug 8, 2021
Merged

Accept v2 infohashes for download#15294
sledgehammer999 merged 1 commit into
qbittorrent:masterfrom
sledgehammer999:accept_v2_infohash

Conversation

@sledgehammer999

Copy link
Copy Markdown
Member

Partially fixes #15287

I am also working on hiding the padding files but the solution is a bit involved. So I made this PR as standalone.

@sledgehammer999 sledgehammer999 added this to the 4.4.0 milestone Aug 6, 2021
Comment thread src/gui/downloadfromurldialog.cpp Outdated
Comment thread src/base/bittorrent/magneturi.cpp Outdated
@Chocobo1 Chocobo1 added the Core label Aug 7, 2021
@glassez

glassez commented Aug 7, 2021

Copy link
Copy Markdown
Member

I am also working on hiding the padding files but the solution is a bit involved.

IMO, we need to completely hide these files behind an abstraction layer. For example, we can keep "file indexes" mapping, so that only the indexes of real files are visible from the outside (this also applies to the visible number of files).
I can do it if you want.

@sledgehammer999

Copy link
Copy Markdown
Member Author

I can do it if you want.

I'll have a draft ready in a few hours. Then we can talk.

@sledgehammer999

Copy link
Copy Markdown
Member Author

@glassez You can go ahead in implementing the hiding of pad files. I went to implement the webapi portion but I see it keeps record of the files differenlty from the GUI part. And I would need to do more extensive internal refactoring. So it is best that you do it because it'll much more time with me.

@sledgehammer999

Copy link
Copy Markdown
Member Author

@glassez a hint: Litbtorrent file_storage has a function that tells us if a certain file is a pad file. You don't need to reinvent the wheel.

@sledgehammer999 sledgehammer999 merged commit 3e92e71 into qbittorrent:master Aug 8, 2021
@sledgehammer999 sledgehammer999 deleted the accept_v2_infohash branch August 8, 2021 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Some 4.4.0beta2 testing results

3 participants