Use c++1z to enable c++17#14148
Closed
sledgehammer999 wants to merge 146 commits into
Closed
Conversation
Our CMake configuration has matured over time, thus require CMake builds to require successful builds on Travis CI.
This block has no significance because these branches are stale and builds will not be triggered on these branches.
limiation -> limitation
option "Disallow connection to peers on privileged ports"
Bump WebAPI version to 2.6.1
The ban action doesn't depend on ipfilter.
In libtorrent 2.0, the `connection_type` was changed to a flag type and hence it cannot be used in a switch statement directly. Also our use of `connection_type` is limited so that a single equality comparison would cover all of our use cases.
Also directly provide display data from model rather then generating it in delegate
The `AC_OUTPUT` has two versions, the deprecated one takes arguments and the other not. Check the following link for equivalent replacement: https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.70/html_node/Obsolete-Macros.html#Obsolete-Macros Also regenerate the configure script with the latest Autoconf 2.70.
Previously it only handle the case of failed lookup, now it discard invalid values when deserializing the database from disk. Also checks whether the data is convertible to the intended type.
This applies to "About Dialog", "Ban List Options Dialog", "Download From URL Dialog", "IP Subnet Whitelist Options Dialog", "Search Plugin Select Dialog", "Search Plugin Source Dialog", "Statistics Dialog", "Speed Limit Dialog" and "Torrent Options Dialog". Also unifies storing the dialog size under the key "Size".
The basic idea is we create a version header template at "src/base/version.h.in" and the build systems are expected to replace strings that are enclosed with @ symbols and generate "src/base/version.h" for other source files to consume/include.
Only set editable flag on item's where editing is handled in the delegate closes qbittorrent#13515
It increases compatibility with older qt versions.
sledgehammer999
force-pushed
the
use_cxx1z
branch
from
279cf19 to
7fe7c6c
Compare
Member
Author
|
Superseded by #14170 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
14 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It increases compatibility with older qt versions.
I discovered this because the ppa-unstable builds are failing for Ubuntu 18.04. It uses qt 5.9.5 and apparently doesn't recognize the
c++17switch. I confirmed locally that thec++1zswitch works.Example failed build log: https://launchpadlibrarian.net/515249118/buildlog_ubuntu-bionic-amd64.qbittorrent_4.4.0~202101031434-7169-04a9ce6e8~ubuntu18.04.1_BUILDING.txt.gz