Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle the format '?' in number formatting #2080

Merged
merged 1 commit into from
Feb 7, 2025
Merged

Conversation

kurtinge
Copy link
Contributor

Handle the format '?' in number formatting

Description

When excelize tries to read a cell where the formatCode in the style is "?" it will return an empty string instead of the number.

Motivation and Context

This handles that the formatCode "?" is valid and returns a the number correctly

How Has This Been Tested

This has been tested in the unit test and with an actual file.

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@xuri xuri added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 4, 2025
Copy link

codecov bot commented Feb 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.20%. Comparing base (4324622) to head (4d7817c).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #2080   +/-   ##
=======================================
  Coverage   99.20%   99.20%           
=======================================
  Files          32       32           
  Lines       30075    30075           
=======================================
  Hits        29837    29837           
  Misses        158      158           
  Partials       80       80           
Flag Coverage Δ
unittests 99.20% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -3635,6 +3635,7 @@ func TestNumFmt(t *testing.T) {
{"123", "[$x.-unknown]MM/DD/YYYY", "x.05/02/1900"},
{"1234.5678", "0.0xxx00", "1234.5xxx68"},
{"80145.899999999994", "[$¥-8004]\" \"#\" \"####\"\"", "¥ 8 0146"},
{"1", "?", "1"},
Copy link
Member

@xuri xuri Feb 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO: support blank padding. For example:

{"1", "???", "  1"},

@xuri xuri merged commit 05ed940 into qax-os:master Feb 7, 2025
29 checks passed
@xuri
Copy link
Member

xuri commented Feb 7, 2025

Thanks for your PR. The case as I commented on above should be supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
Status: Bugfix
Development

Successfully merging this pull request may close these issues.

2 participants