-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the compatibility of the number format #1951
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left some comments. Please add unit test for this changes.
Hi @peng, I fixed the code review issue, please take a look. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job. Please also add unit test with [$-x-sysdate]
number format code.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1951 +/- ##
=======================================
Coverage 99.31% 99.31%
=======================================
Files 32 32
Lines 25230 25250 +20
=======================================
+ Hits 25058 25078 +20
Misses 92 92
Partials 80 80
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Great work! Thanks for your contribution.
PR Details
Represents language ID in decimal
Description
Add support for applying number format expression with language/location tags, to improve the compatibility of the number format for the Excelize.
Related Issue
N/A
Motivation and Context
Improve the compatibility of the number format
How Has This Been Tested
Complete documentation and unit tests, written unit test code in the numfmt_test.go source code, incremental test coverage of line should be 100%
Types of changes
Checklist