Fix corrupted utf-8 strings after trimming cell values #1517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Usage value[:TotalCellChars] is incorrect. If value contains utf-8 string it may corrupt the last symbol in value.
|
Maybe it is better to use |
xuri
added
the
size/S
xuri
requested changes
Apr 10, 2023
xuri
reviewed
Apr 10, 2023
|
It's done, but "resolve conversation" button doesn't work. Don't know why :( |
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #1517 +/- ##
=======================================
Coverage 98.66% 98.66%
=======================================
Files 31 31
Lines 24337 24337
=======================================
Hits 24013 24013
Misses 214 214
Partials 110 110
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xuri
approved these changes
Apr 12, 2023
fudali113
pushed a commit
to fudali113/excelize
that referenced
this pull request
Apr 17, 2023
xuri
pushed a commit
to JDavidVR/excelize
that referenced
this pull request
Jul 11, 2023
jenbonzhang
pushed a commit
to jenbonzhang/excelize
that referenced
this pull request
Oct 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage value[:TotalCellChars] is incorrect. If value contains utf-8 string it may corrupt the last symbol in value.
PR Details
Bug fix of slicing strings in Go
Description
Excel has upper limit of character count which is 32767, but excelize checks value length by bytes instead by characters.
If I put utf-8 value (repeated 17000 times two-bytes symbol "Ы", for example) to a cell, excelize won't show any error, but file will be corrupted. Excel will show error on this file. Mac Numbers doesn't show any error, but empty cell and half-empty file.
Related Issue
[
](https://github.com//issues/1518)Motivation and Context
How Has This Been Tested
Types of changes
Checklist