Stream writer improvements #1123
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this will give more flexibility to header modifications
xuri
added
the
size/M
the validity of the sheet is tested outside now
the function was changed to allow being called after data has been written
this fixes the GetCellValue not working on streams after the bufferedWriter changes this also fixes GetCellValue on large streams that spill to tmp file
harrison3000
changed the title
|
please review this PR, I have nothing more to add, it just need the finishing touches |
Codecov Report
@@ Coverage Diff @@
## master #1123 +/- ##
=======================================
Coverage 98.44% 98.44%
=======================================
Files 31 31
Lines 23459 23469 +10
=======================================
+ Hits 23095 23105 +10
Misses 242 242
Partials 122 122
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
xuri
requested changes
Jan 28, 2022
- New exported error `ErrStreamSetPanes` has been added
xuri
approved these changes
Oct 10, 2022
xuri
pushed a commit
to JDavidVR/excelize
that referenced
this pull request
Jul 11, 2023
- New exported error `ErrStreamSetPanes` has been added
jenbonzhang
pushed a commit
to jenbonzhang/excelize
that referenced
this pull request
Oct 22, 2023
- New exported error `ErrStreamSetPanes` has been added
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR adds miscellaneous improvements to the stream writer API
Description
Related Issue
#1047
Motivation and Context
These changes make the stream API more flexible and less restricted
How Has This Been Tested
For now I only tested generating large sheets with real world data
I also looked at the xml and compared to another xml generated on normal mode
Automated tests on the way
Types of changes
Checklist