time parse error

[hotfireeagle]

the excel data:

after parse, the output is:

the code is:

[danielbprice]

(I am not a maintainer here, but): did you try running from the top of the tree, i.e. from master? Because other time parsing bugs have been fixed since the most recent release. I recently hit #1080 which isn't that different.

[hotfireeagle]

my excelize version is v2.4.2

[xuri]

This issue is duplicated with #764, #1030, #1070 and #1073 please upgrade to the master branch code, and this patch will be released in the next version v2.5.0:

go get -u github.com/xuri/excelize/v2@master
go mod tidy

[skytodmoon]

@xuri @danielbprice Have you resolved this problem? I met same after:
go get -u github.com/xuri/excelize/v2@master
go mod tidy
version:v2.4.2-0.20211219053624-6051434bf898

[xuri]

This issue has been fixed. Could you provide spreadsheet attachment and standalone code to reproduce this issue?

[skytodmoon]

@xuri

ENV:
MAC Big Sur 11.4
WPS 3.7.0
go mod:
`go 1.16

require (
github.com/xuri/excelize/v2 v2.4.2-0.20211219053624-6051434bf898
golang.org/x/crypto v0.0.0-20211215153901-e495a2d5b3d3 // indirect
golang.org/x/net v0.0.0-20211216030914-fe4d6282115f // indirect
golang.org/x/text v0.3.7 // indirect
)`

attachments: test.xlsx

func main() {
	f, err := excelize.OpenFile("test.xlsx")
	if err != nil {
		fmt.Println(err)
		return
	}
	defer func() {
		// Close the spreadsheet.
		if err := f.Close(); err != nil {
			fmt.Println(err)
		}
	}()
	// Get value from cell by given worksheet name and axis.
	cell, err := f.GetCellValue("Sheet1", "B2")
	if err != nil {
		fmt.Println(err)
		return
	}
	fmt.Println(cell)
	// Get all the rows in the Sheet1.
	rows, err := f.GetRows("Sheet1")
	if err != nil {
		fmt.Println(err)
		return
	}
	for _, row := range rows {
		for _, colCell := range row {
			//fmt.Print(colCell, "\t")
			fmt.Printf("%s\n",colCell)
		}
		fmt.Println()
	}
}

result:

'12-17-21

12-18-21

12-19-21

12-20-21

12-21-21

12-22-21
'

[xuri]

The file attachments upload failed.

[skytodmoon]

@xuri uploaded.

[xuri]

This patch fixed the accuracy issue on parsing cells with time number format in some cases, but not related to language location. The library support parsing build-in date and time number format under English (United States) currently, so the cell value should be concat with a dash (not slash) after applying the number format, I'll consider adding language location support later.