qandidate/toggle ^2.0

qandidate-labs · Mar 30, 2020 · c5a89de · c5a89de
1 parent ba632bf
commit c5a89de
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 9 deletions.
diff --git a/app/bootstrap.php b/app/bootstrap.php
@@ -103,11 +103,7 @@
 });
 
 $app->delete('/toggles/{name}', function ($name) use ($app) {
-    $removed = $app['toggle.manager']->remove($name);
-
-    if (!$removed) {
-        return new Response(sprintf('Unable to delete toggle "%s"', $name), 400);
-    }
+    $app['toggle.manager']->remove($name);
 
     return new Response('OK');
 });

diff --git a/composer.json b/composer.json
@@ -25,13 +25,13 @@
         "php": ">=7.2",
         "ext-json": "*",
         "silex/silex": "^1.0",
-        "qandidate/toggle": "^0.2@dev",
+        "qandidate/toggle": "^2.0",
         "predis/service-provider": "^0.4@dev",
         "asm89/stack-cors": "^1.0",
         "vlucas/phpdotenv": "^2.0"
     },
     "require-dev": {
-        "symfony/browser-kit": "^3.4||^4.0||^5.0",
+        "symfony/browser-kit": "^3.4",
         "phpunit/phpunit": "~4.8",
         "broadway/coding-standard": "^1.0",
         "phpstan/phpstan": "@stable"

diff --git a/test/Qandidate/Application/Toggle/TogglesEndpointTest.php b/test/Qandidate/Application/Toggle/TogglesEndpointTest.php
@@ -49,6 +49,7 @@ public function it_exposes_all_toggle_names(): void
                             ],
                         ],
                         'status' => 'conditionally-active',
+                        'strategy' => 'affirmative',
                     ],
                 ]
             ),
@@ -76,12 +77,12 @@ public function it_can_delete_a_toggle(): void
     /**
      * @test
      */
-    public function it_returns_400_on_deleting_non_existing_toggle(): void
+    public function it_does_not_error_when_deleting_non_existing_toggle(): void
     {
         $client = $this->createClient();
         $crawler = $client->request('DELETE', '/toggles/nothere');
 
-        $this->assertFalse($client->getResponse()->isOk());
+        $this->assertTrue($client->getResponse()->isOk());
     }
 
     /**
@@ -99,6 +100,7 @@ public function it_updates_a_toggle_on_put(): void
                 ],
             ],
             'status' => 'conditionally-active',
+            'strategy' => 'affirmative',
         ];
         $toggle = json_encode($toggleData);