Missing right margin / padding in admin bar language dropdown

[ihorvorotnov]

Checked with current master branch and .org version of the plugin. Here's the screenshot:

Will check the code tomorrow and send a PR.

[johnclause]

Hi, Ihor, Any progress on this? I am glad you noticed this.

[ihorvorotnov]

@johnclause I fixed it on my local install but it's a bit hacky - there's a little problem with markup. See the screenshot - there's missing active background color right after the flag, because the flag is positioned with background-position: right; - it can't be padded.

I'll fix it properly in next few days.

And also I've modified language tabs styles - the default styles are way off the WP styles (underlined links, gradient background etc). If you like it, I can make it as another option or replace the default one. Here it is:

Not a final version though - there's some issues with inconsistent margins on different pages / positions. What do you think?

[johnclause]

Thanks a lot. How was that before when it was working right?

Let us not modify the default, this will upset a lot of people, who got used to it already. Custom LSB styles can be added under folder "admin/css/opLSBStyle", where they are automatically get loaded from.

[johnclause]

I partially fixed it through PHP code cited above.

"background-position: right 5px center;" works well everywhere, but safari.

Did you make anymore progress?

[benique]

@johnclause background-position: right 5px center; works in Safari 9. I've used it in earlier versions as well.

[johnclause]

Wow, indeed I have Safari 5.1.7, but I installed it like a year ago, how am I so outdated. I am talking about Safari on Windows. I went to http://www.apple.com/safari/ and cannot find download button, who do you upgrade?

Anyway, the way menu now, in the latest on GitHub, seems to be good enough, is not it?

I am closing this issue to move forward, we can still write into a closed issue same way as before, or we can re-open it, if needed later.

[benique]

@johnclause Safari for Windows was unfortunately retired in 2012.

[johnclause]

I tested it on ipad, indeed it works. Anyway I like the way it is now even better. Flags in drop down a shifted a little bit with respect to top flag, but it looks even better to me. Do you think I should change something?