Add support for Wemo CrockPot Slow Cooker#293
Add support for Wemo CrockPot Slow Cooker#293esev merged 8 commits intopywemo:mainfrom alexanv1:master
Conversation
|
@esev could you please take a look at this when you get a chance. |
esev
left a comment
There was a problem hiding this comment.
Just a few lint issues found. See the details in the failing checks.
I think just running isort & black should take care of them. There is a scripts/build.sh file that should take care of running these too.
Very nice. Thank you for this PR. |
Thanks! Should be fixed now. |
|
One more thing, @alexanv1 . If you have time, please consider contributing an integration test for the CrockPot. This helps us validate changes when we don't have the device to test with. We use the vcr library to record/replay the actual request/responses from the device. |
|
@esev, thanks for merging and releasing the update! |
|
@alexanv1 just FYI I bumped the pywemo version in Home Assistant. It includes this PR now. |
Description:
Add support for Wemo CrockPot Slow Cooker
Old device that's probably out of production at this point but still supported by Wemo. I've been running with this for awhile but finally got around to contributing the changes after cleaning them up.
Related issue (if applicable): fixes #
Checklist: