Skip to content

Add support for Wemo CrockPot Slow Cooker#293

Merged
esev merged 8 commits intopywemo:mainfrom
alexanv1:master
Nov 13, 2021
Merged

Add support for Wemo CrockPot Slow Cooker#293
esev merged 8 commits intopywemo:mainfrom
alexanv1:master

Conversation

@alexanv1
Copy link
Copy Markdown
Contributor

@alexanv1 alexanv1 commented Oct 29, 2021

Description:

Add support for Wemo CrockPot Slow Cooker

Old device that's probably out of production at this point but still supported by Wemo. I've been running with this for awhile but finally got around to contributing the changes after cleaning them up.

Related issue (if applicable): fixes #

Checklist:

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • I have read and agree to the CONTRIBUTING document.

@alexanv1
Copy link
Copy Markdown
Contributor Author

@esev could you please take a look at this when you get a chance.
Thanks!

Copy link
Copy Markdown
Member

@esev esev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few lint issues found. See the details in the failing checks.

I think just running isort & black should take care of them. There is a scripts/build.sh file that should take care of running these too.

@esev
Copy link
Copy Markdown
Member

esev commented Oct 31, 2021

@esev could you please take a look at this when you get a chance. Thanks!

Very nice. Thank you for this PR.

@alexanv1
Copy link
Copy Markdown
Contributor Author

Just a few lint issues found. See the details in the failing checks.

I think just running isort & black should take care of them. There is a scripts/build.sh file that should take care of running these too.

Thanks! Should be fixed now.

@alexanv1 alexanv1 closed this Oct 31, 2021
@alexanv1 alexanv1 reopened this Oct 31, 2021
@alexanv1 alexanv1 requested a review from esev October 31, 2021 20:56
Copy link
Copy Markdown
Member

@esev esev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a few more pylint/flake8 updates to this PR. build.sh completes successfully now.

The current check failure is unrelated to this PR. I've fixed the underlying issue in #294.

@esev esev merged commit a8c1a9c into pywemo:main Nov 13, 2021
@esev
Copy link
Copy Markdown
Member

esev commented Nov 13, 2021

Thank you again for this PR @alexanv1

I created a new release, version 0.6.8, that includes your change.

@esev
Copy link
Copy Markdown
Member

esev commented Nov 13, 2021

One more thing, @alexanv1 . If you have time, please consider contributing an integration test for the CrockPot. This helps us validate changes when we don't have the device to test with. We use the vcr library to record/replay the actual request/responses from the device.

See #205, #207, #208, and #214 for examples.

@alexanv1
Copy link
Copy Markdown
Contributor Author

@esev, thanks for merging and releasing the update!
Sure, I will see if I can add integration tests within the few days if I have some time to figure out the vcr library.

@esev
Copy link
Copy Markdown
Member

esev commented Dec 20, 2021

@alexanv1 just FYI I bumped the pywemo version in Home Assistant. It includes this PR now.
home-assistant/core#62360

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants