-
Notifications
You must be signed in to change notification settings - Fork 37
MAINT: Fixes for NumPy deprecation and 3.10 #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 29 commits
Commits
Show all changes
32 commits
Select commit
Hold shift + click to select a range
34a39e6
MAINT: Fix for NumPy deprecation
larsoner 6d4b003
FIX: CIs?
larsoner dbeda5e
FIX: Name
larsoner 4b0db23
FIX: Name
larsoner 4e75089
2_24?
larsoner 8fcc167
Give 2014 a chance
larsoner 3db1dda
FIX: Try
larsoner 2653bd8
FIX: Just Linux and macOS now
larsoner 5a44231
FIX: macOS
larsoner abac074
FIX: macOS
larsoner 803bb22
FIX: Spacing
larsoner 5ede80f
FIX: Version parse
larsoner 316c848
FIX: Version parse
larsoner b7f0362
FIX: 3.10
larsoner 9e757d6
FIX: macOS
larsoner b9f4d8d
FIX: macOS
larsoner ea5c29f
FIX: Missed
larsoner 0d814ee
FIX: Lines
larsoner 0b72139
FIX: Lines
larsoner 0d7311a
FIX: Lines
larsoner 92b1f38
FIX: Try again
larsoner a877512
FIX: vvverbose
larsoner 2c563b6
FIX: pip
larsoner 2c640cd
FIX: matrix?
larsoner 6e9e147
FIX: Debug
larsoner 9e7a602
FIX: auditwheel
larsoner aab674a
FIX: wheel
larsoner 96c3024
FIX: Direct
larsoner e98e959
FIX: Whatever
larsoner fe966a9
FIX: Simplify
larsoner 9b3fe52
FIX: Version
larsoner 890a092
FIX: Simplify
larsoner File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,4 +1,5 @@ | ||
| setuptools>=41.0.0 | ||
| wheel>=0.33.0 | ||
| numpy<1.20.0 | ||
| numpy<1.20.0; python_version >= '3.7' and python_version <= '3.9' | ||
| numpy<=1.21.3; python_version >= '3.10' | ||
| cython>=0.29.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally on my 12.3 Monterey install I cannot reproduce this issue, but on GH actions there is some problem installing this wheel despite many attempts at debugging. So here I just hack the filename to make it seem like at 10_16 wheel so that
pipwill install it.It's a hack but I think it's acceptable since we want a 3.10 wheel for this package, and this hack can go away once VTK releases 9.2 with 3.10 wheels in the coming weeks (!?)