Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update libdatatrie to 6ef4485474890606946ed208ff453231b581cdf1 #75

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

c4f3a0ce
Copy link

@c4f3a0ce c4f3a0ce commented Dec 8, 2019

This PR

Resolves #74

@c4f3a0ce
Copy link
Author

c4f3a0ce commented Dec 8, 2019

So it seems that it doesn't resolve the problem completely. It is less prominent, but some segfaults still occur (https://travis-ci.org/pytries/datrie/jobs/622241476).

@c4f3a0ce
Copy link
Author

c4f3a0ce commented Dec 8, 2019

Also this falsifying example:

trie = datrie.Trie([chr(i) for i in range(1500)])
trie['ÿ0'] = True
trie['foo'] =  True

'foo' in trie
# True
'ÿ0' in trie                                                                                   
# False

is troubling. Seems related to nil in the alphabet:

trie_without_nil = datrie.Trie([chr(i) for i in range(1, 1500)])
trie_without_nil['ÿ0'] = True

'ÿ0' in trie_without_nil
# True

Which kind of makes sense.

Maybe @thep can shed some light on this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory corruption with slighthly bigger alphabets.
1 participant