Use shard_as in scan to ensure that inputs and their gradients have the same sharding #8879
+281
−59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tengyifei
force-pushed
the
yifeit/scan-shard-as
branch
2 times, most recently
from
705814f to
b2140fa
Compare
tengyifei
force-pushed
the
yifeit/scan-shard-as
branch
from
b2140fa to
ba4b6ab
Compare
qihqi
approved these changes
Mar 28, 2025
tengyifei
force-pushed
the
yifeit/scan-shard-as
branch
from
5f84ac1 to
9dcfe1c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #8883. See #8883 for explanation.