Lower cummax op #8491
Open
Lower cummax op #8491
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement cummax op. Fixes #8230
Cummax returns a tuple of (values, indices). This PR uses the
ReduceWindowWithGeneralPaddingXLA op (padding + window reducer for cumulative values) to implement it similar to cumsum/cumprod. The only difference is that the indices will be passed to theReduceWindowWithGeneralPaddingop along with the values, and a new reducer is implemented to look at both the value and index of input and return a tuple of (max_value, max_index).