Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

XLA downcast for S64 and U64 for Neuron #8347

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

XLA downcast for S64 and U64 for Neuron #8347

wants to merge 2 commits into from

Conversation

aws-nm9
Copy link

@aws-nm9 aws-nm9 commented Oct 31, 2024

This PR downcasts the S64 and U64 datatypes for Neuron devices, to prevent unsupported datatypes from being lowered to the compiler.

@jeffhataws
Copy link
Collaborator

@qihqi will you look at this one also? it is related to #8335

ptoulme-aws
ptoulme-aws approved these changes Nov 4, 2024
View reviewed changes
Copy link

@ptoulme-aws ptoulme-aws left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I am also tracking this on Jax side jax-ml/jax#24682

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rpsilva-aws rpsilva-aws rpsilva-aws approved these changes

@ptoulme-aws ptoulme-aws ptoulme-aws approved these changes

@jeffhataws jeffhataws jeffhataws approved these changes

@miladm miladm Awaiting requested review from miladm

@JackCaoG JackCaoG Awaiting requested review from JackCaoG

@aws-kingrj aws-kingrj Awaiting requested review from aws-kingrj

@qihqi qihqi Awaiting requested review from qihqi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@aws-nm9 @jeffhataws @ptoulme-aws @rpsilva-aws