Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[benchmarks] Fix verifier error handling and OOM. #7777

Merged
merged 4 commits into from
Aug 5, 2024

Conversation

ysiraichi
Copy link
Collaborator

In summary, this PR:

  • Skips the actual experiment when running the verifier, i.e. goes directly into the verifier code, instead of running the experiment first (the experiment is still run in the end of the verifier, though)
  • Handles errors when running the model on fp64, turning cosine similarity verification ON on any exception
  • Renames a few confusing VerificationCode enum names

cc @miladm @JackCaoG @zpcore

benchmarks/verifier.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@zpcore zpcore left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@ysiraichi ysiraichi merged commit 5bbc4b3 into master Aug 5, 2024
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants