Reland: mul: convert inputs to result type.
#7602
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ysiraichi
commented
Jul 1, 2024
| @@ -158,7 +158,7 @@ class OpConfig { | |||
| inputs.begin(), inputs.end(), [](const at::Tensor& tensor) { | |||
| return bridge::TryGetXlaTensor(tensor); | |||
| }); | |||
| XLA_CHECK(it != inputs_.end()); | |||
| XLA_CHECK(it != inputs.end()); | |||
There was a problem hiding this comment.
Previously, incorrectly checking against inputs_ instead of inputs.
There was a problem hiding this comment.
man! I should catch this during reviewing haha
There was a problem hiding this comment.
Must admit that it was NOT (wow, what a typo) the best naming choice, though.
There was a problem hiding this comment.
nice catch 🤣 , I will check the TPU CI after this pr is merged.
There was a problem hiding this comment.
Again, sorry for the typo there. That was really bad.
JackCaoG
approved these changes
Jul 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #7266
This PR tries to re-land #7130, which was reverted due to regressions on XLA:TPU. On top of that, it also fixes a subtle bug that went under the radar. Although we couldn't find a minimal reproducer, internal CI for TPU was reportedly broken due to this PR.
Therefore, the idea is to have this PR merged, and check the internal CI for TPU results.
cc @miladm @vanbasten23 @JackCaoG