[LTC] Inherits LazyGraphExecutor::DeviceContextArena #4307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alanwaketan
force-pushed
the
alanwaketan/lazy_graph_3
branch
from
ef8b2fd to
30cb306
Compare
JackCaoG
approved these changes
Dec 10, 2022
alanwaketan
force-pushed
the
alanwaketan/lazy_graph_3
branch
from
30cb306 to
a132b4c
Compare
Merged
alanwaketan
force-pushed
the
alanwaketan/lazy_graph_3
branch
from
a132b4c to
ad8696a
Compare
wonjoo-wj
approved these changes
Dec 12, 2022
Collaborator
Author
|
Thanks Jack and Wonjoo. |
pytorchmergebot
pushed a commit
to pytorch/pytorch
that referenced
this pull request
Dec 13, 2022
Summary: This patch makes DeviceContextArena protected such that XLAGraphExecutor can reuse it. In addition, it makes all methods that utilize DeviceContextArena virtual such that XLAGraphExecutor can override them to provide its own DeviceContextArena. P.S. This patch depends on pytorch/xla#4307 too. Test Plan: CI. Pull Request resolved: #90531 Approved by: https://github.com/antoniojkim, https://github.com/JackCaoG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This patch inherits LazyGraphExecutor::DeviceContextArena and overrides the follow methods:
In addition, it has an extra method: GetBaseSeedData that is used by dynamo.
This patch needs pytorch/pytorch#90531 to function.
Test Plan:
CI.