Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing model tracing step to cpp example readme, fixes #7952 #7963

Merged
merged 5 commits into from
Sep 18, 2023

Conversation

abstractionmage
Copy link
Contributor

When you follow the instructions for building and running the c++ hello_world example project, you will get the message error loading the model printed to the console.

This is because trace_model.py is never called, so the model file resnet18.pt is never created and also never copied over to the build folder where the compiled binary expects it to be.

In issue #7952, pmeier suggested that the tracing step shoud be added to the example projec's readme.md, which this PR does.

@pytorch-bot
Copy link

pytorch-bot bot commented Sep 15, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/pytorch/vision/7963

Note: Links to docs will display an error until the docs builds have been completed.

❌ 22 New Failures, 10 Unrelated Failures

As of commit 9e61220 with merge base b6574c9 (image):

NEW FAILURES - The following jobs have failed:

FLAKY - The following jobs failed but were likely due to flakiness present on trunk:

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pmeier pmeier linked an issue Sep 18, 2023 that may be closed by this pull request
Copy link
Collaborator

@pmeier pmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pmeier pmeier merged commit d7c20dd into pytorch:main Sep 18, 2023
@github-actions
Copy link

Hey @pmeier!

You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py

@abstractionmage abstractionmage deleted the cpp-example-model-not-traced branch September 23, 2023 00:01
facebook-github-bot pushed a commit that referenced this pull request Sep 26, 2023
…7952 (#7963)

Summary: Co-authored-by: Philip Meier <[email protected]>

Reviewed By: matteobettini

Differential Revision: D49600787

fbshipit-source-id: 9f3fdbbbddea9c220f600ed6b9b1862f9357f8fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Model not traced in the cpp example project
3 participants