Added an "s" to match the function name #7394
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update the _BETA_TRANSFORMS_WARNING string that currently prints a function that does not exist. An "s" is added. From torchvision.disable_beta_transform_warning() to torchvision.disable_beta_transforms_warning()
pmeier
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Thanks @camilodlt! @NicolasHug can we maybe cherry-pick this one or is it too late?
| @@ -105,7 +105,7 @@ def _is_tracing(): | |||
| "this issue: https://github.com/pytorch/vision/issues/6753, and you can also " | |||
| "check out https://github.com/pytorch/vision/issues/7319 to learn more about " | |||
| "the APIs that we suspect might involve future changes. " | |||
| "You can silence this warning by calling torchvision.disable_beta_transform_warning()." | |||
| "You can silence this warning by calling torchvision.disable_beta_transforms_warning()." | |||
There was a problem hiding this comment.
For reference:
vision/torchvision/__init__.py
Line 112 in beb4bb7
NicolasHug
approved these changes
Mar 7, 2023
There was a problem hiding this comment.
Ah shoot. Thanks a lot @camilodlt . I'll cherry-pick it, but IDK if a new RC will be triggered before the release :/
|
Hey @NicolasHug! You merged this PR, but no labels were added. The list of valid labels is available at https://github.com/pytorch/vision/blob/main/.github/process_commit.py |
NicolasHug
pushed a commit
to NicolasHug/vision
that referenced
this pull request
Mar 7, 2023
This was referenced Mar 7, 2023
pmeier
added
the
other
facebook-github-bot
pushed a commit
that referenced
this pull request
Mar 30, 2023
Reviewed By: vmoens Differential Revision: D44416573 fbshipit-source-id: cb57b893dab3a34601b534079e7b5e7a7b5209c8
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the _BETA_TRANSFORMS_WARNING string that currently prints a function that does not exist. An "s" is added. From torchvision.disable_beta_transform_warning() to torchvision.disable_beta_transforms_warning()